This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Armv8.4-A: Virtualization system registers
ClosedPublic

Authored by SjoerdMeijer on Jun 28 2018, 2:10 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

SjoerdMeijer created this revision.Jun 28 2018, 2:10 AM
olista01 accepted this revision.Jun 28 2018, 2:37 AM

It would be worth clarifying in the comments and commit message that this is the "Secure EL2" extension, to avoid confusion with the "Enhanced Support for Nested Virtualization" extension, which I assume will be in a later patch.

Other than that, LGTM.

test/MC/Disassembler/AArch64/armv8.4a-vir.txt
1 ↗(On Diff #153276)

Should the file name be armv8.4a-virt.txt, for consistency with the assembly test?

This revision is now accepted and ready to land.Jun 28 2018, 2:37 AM

Thanks for the suggestion: will clarify that this is indeed "Secure EL2" extension, and the "Enhanced Support for Nested Virtualization" will follow.
I was thinking of keeping the patches small and manageable, but might do the rest of all these system registers in one go; will put something up for review soon.

I will change the file name before committing.

This revision was automatically updated to reflect the committed changes.