CFI: Print DSO names for failed cross-DSO icalls

[vlad.tsyrklevich]

• Print cross-DSO diagnostic for C++ CFI failures as well

[pcc]

test/cfi/cross-dso-diagnostic.cpp

20 ↗

(On Diff #152833)

Would it be possible to improve the diagnostic testing here? I'm thinking that you could have the test build a DSO named with a specific suffix, name the executable using a different suffix and test for both suffixes here (and below).

[vlad.tsyrklevich]

• Better diagnostic path checking using suffixes and an actual DSO

[pcc]

LGTM

test/cfi/cross-dso-diagnostic.cpp

7 ↗

(On Diff #152834)

I think you also need // UNSUPPORTED: win32.

[eugenis]

The test fails on Android:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/12072/steps/run%20lit%20tests%20%5Bi686%2Ffugu-userdebug%2FN2G48C%5D/logs/stdio

lib/ubsan/ubsan_handlers.cc

Diag(Loc, DL_Error, ET,
        "control flow integrity check for type %0 failed during %1")
       << Data->Type << CheckKindStr;
 
   SymbolizedStackHolder FLoc(getSymbolizedLocation(Function));
   const char *FName = FLoc.get()->info.function;
   if (!FName)
     FName = "(unknown)";
   Diag(FLoc, DL_Note, ET, "%0 defined here") << FName;
+
+  // If the failure occurred due to a cross-DSO icall, report the DSO names.
+  const char *DstModule = FLoc.get()->info.module;
+  if (!DstModule)
+    DstModule = "(unknown)";
+
+  SymbolizedStackHolder CalleeLoc(getCallerLocation(Opts.pc));
+  const char *SrcModule = CalleeLoc.get()->info.module;
+  if (!SrcModule)
+    SrcModule = "(unknown)";
+
+  if (internal_strcmp(SrcModule, DstModule))
+    Diag(CalleeLoc, DL_Note, ET,
+         "check failed in %0, destination function located in %1")
+        << SrcModule << DstModule;
 }
 
 namespace __ubsan {
 
 #ifdef UBSAN_CAN_USE_CXXABI
 
 #ifdef _WIN32
 

test/cfi/icall/bad-cross-dso.c

+// Check that cross-DSO icalls diagnostics print the names of both modules
+
+// RUN: %clang -o %t1 %s -ldl
+// RUN: %t1 2>&1 | FileCheck --check-prefix=NCFI %s
+
+// RUN: %clang_cfi -o %t2 %s -ldl
+// RUN: %expect_crash %t2 2>&1 | FileCheck --check-prefix=CFI %s
+
+// RUN: %clang_cfi_diag -g -o %t3 %s -ldl
+// RUN: %t3 2>&1 | FileCheck --check-prefix=CFI-DIAG %s
+
+#define _GNU_SOURCE  // For RTLD_DEFAULT
+#include <stdio.h>
+#include <dlfcn.h>
+
+int main() {
+  // CFI: 1
+  // NCFI: 1
+  fprintf(stderr, "1\n");
+
+  // CFI-DIAG: runtime error: control flow integrity check for type 'void (int)' failed during indirect function call
+  // CFI-DIAG: getpid defined here
+  // CFI-DIAG: check failed in {{.*}}, destination function located in {{.*}}
+  void (*fp)(int) = dlsym(RTLD_DEFAULT, "getpid");
+  fp(1); // UB here
+
+  // CFI-NOT: 2
+  // NCFI: 2
+  fprintf(stderr, "2\n");
+}