CFI: Print DSO names for failed cross-DSO icalls

[vlad.tsyrklevich]

• Print cross-DSO diagnostic for C++ CFI failures as well

[pcc]

test/cfi/cross-dso-diagnostic.cpp

21

Would it be possible to improve the diagnostic testing here? I'm thinking that you could have the test build a DSO named with a specific suffix, name the executable using a different suffix and test for both suffixes here (and below).

[vlad.tsyrklevich]

• Better diagnostic path checking using suffixes and an actual DSO

[pcc]

LGTM

test/cfi/cross-dso-diagnostic.cpp

8

I think you also need // UNSUPPORTED: win32.

[eugenis]

The test fails on Android:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/12072/steps/run%20lit%20tests%20%5Bi686%2Ffugu-userdebug%2FN2G48C%5D/logs/stdio

lib/ubsan/ubsan_handlers.cc

Diag(Loc, DL_Error, ET,
        "control flow integrity check for type %0 failed during %1")
       << Data->Type << CheckKindStr;
 
   SymbolizedStackHolder FLoc(getSymbolizedLocation(Function));
   const char *FName = FLoc.get()->info.function;
   if (!FName)
     FName = "(unknown)";
   Diag(FLoc, DL_Note, ET, "%0 defined here") << FName;
+
+  // If the failure involved different DSOs for the check location and icall
+  // target, report the DSO names.
+  const char *DstModule = FLoc.get()->info.module;
+  if (!DstModule)
+    DstModule = "(unknown)";
+
+  const char *SrcModule = Symbolizer::GetOrInit()->GetModuleNameForPc(Opts.pc);
+  if (!SrcModule)
+    SrcModule = "(unknown)";
+
+  if (internal_strcmp(SrcModule, DstModule))
+    Diag(Loc, DL_Note, ET,
+         "check failed in %0, destination function located in %1")
+        << SrcModule << DstModule;
 }
 
 namespace __ubsan {
 
 #ifdef UBSAN_CAN_USE_CXXABI
 
 #ifdef _WIN32
 

lib/ubsan/ubsan_handlers_cxx.cc

void __ubsan_handle_cfi_bad_type(CFICheckFailData *Data, ValueHandle Vtable,
   }
 
   Diag(Loc, DL_Error, ET,
        "control flow integrity check for type %0 failed during "
        "%1 (vtable address %2)")
       << Data->Type << CheckKindStr << (void *)Vtable;
 
   // If possible, say what type it actually points to.
-  if (!DTI.isValid()) {
-    const char *module = Symbolizer::GetOrInit()->GetModuleNameForPc(Vtable);
-    if (module)
-      Diag(Vtable, DL_Note, ET, "invalid vtable in module %0") << module;
-    else
-      Diag(Vtable, DL_Note, ET, "invalid vtable");
-  } else {
+  if (!DTI.isValid())
+  else
     Diag(Vtable, DL_Note, ET, "vtable is of type %0")
         << TypeName(DTI.getMostDerivedTypeName());
-  }
+
+  // If the failure involved different DSOs for the check location and vtable,
+  // report the DSO names.
+  const char *DstModule = Symbolizer::GetOrInit()->GetModuleNameForPc(Vtable);
+  if (!DstModule)
+    DstModule = "(unknown)";
+
+  const char *SrcModule = Symbolizer::GetOrInit()->GetModuleNameForPc(Opts.pc);
+  if (!SrcModule)
+    SrcModule = "(unknown)";
+
+  if (internal_strcmp(SrcModule, DstModule))
+    Diag(Loc, DL_Note, ET, "check failed in %0, vtable located in %1")
+        << SrcModule << DstModule;
 }
 }  // namespace __ubsan
 
 #endif // CAN_SANITIZE_UB

test/cfi/cross-dso-diagnostic.cpp

+// Check that cross-DSO diagnostics print the names of both modules
+
+// RUN: %clangxx_cfi_diag -g -DSHARED_LIB -fPIC -shared -o %t_dso_suffix %s
+// RUN: %clangxx_cfi_diag -g -o %t_exe_suffix %s -ldl
+// RUN: %t_exe_suffix %t_dso_suffix 2>&1 | FileCheck %s
+
+// UNSUPPORTED: win32
+// REQUIRES: cxxabi
+
+#include <dlfcn.h>
+#include <stdio.h>
+
+struct S1 {
+  virtual void f1();
+};
+
+#ifdef SHARED_LIB
+
+void S1::f1() {}
+
+__attribute__((visibility("default"))) extern "C"
+void* dso_symbol() { return new S1(); }
+
+#else
+
+int main(int argc, char *argv[]) {
+  void *handle = dlopen(argv[1], RTLD_NOW);
+
+  // CHECK: runtime error: control flow integrity check for type 'void *()' failed during indirect function call
+  // CHECK: dso_symbol defined here
+  // CHECK: check failed in {{.*}}_exe_suffix, destination function located in {{.*}}_dso_suffix
+  void* (*fp)(void) =
+      reinterpret_cast<void*(*)(void)>(dlsym(handle, "dso_symbol"));
+  void *S = fp(); // trigger cfi-icall failure
+
+  // CHECK: runtime error: control flow integrity check for type 'S1' failed during cast to unrelated type
+  // CHECK: invalid vtable
+  // CHECK: check failed in {{.*}}_exe_suffix, vtable located in {{.*}}_dso_suffix
+  S1 *Scast = reinterpret_cast<S1*>(S); // trigger cfi-unrelated-cast failure
+}
+
+#endif // SHARED_LIB