Page MenuHomePhabricator

CFI: Print DSO names for failed cross-DSO icalls
ClosedPublic

Authored by vlad.tsyrklevich on Jun 25 2018, 8:21 PM.

Diff Detail

Event Timeline

  • Print cross-DSO diagnostic for C++ CFI failures as well
pcc added inline comments.Jun 25 2018, 9:17 PM
test/cfi/cross-dso-diagnostic.cpp
21

Would it be possible to improve the diagnostic testing here? I'm thinking that you could have the test build a DSO named with a specific suffix, name the executable using a different suffix and test for both suffixes here (and below).

  • Better diagnostic path checking using suffixes and an actual DSO
pcc accepted this revision.Jun 26 2018, 11:30 AM

LGTM

test/cfi/cross-dso-diagnostic.cpp
8

I think you also need // UNSUPPORTED: win32.

This revision is now accepted and ready to land.Jun 26 2018, 11:30 AM
This revision was automatically updated to reflect the committed changes.