This is an archive of the discontinued LLVM Phabricator instance.

Differential D48300

[VPlan] Add Analysis and Core to LLVM_LINK_COMPONENTS
ClosedPublic

Authored by aheejin on Jun 18 2018, 3:14 PM.

Details

Reviewers
fhahn
dschuff
Commits
rG56e127102036: [VPlan] Add Analysis and Core to LLVM_LINK_COMPONENTS
rL334997: [VPlan] Add Analysis and Core to LLVM_LINK_COMPONENTS
Summary

Without these, build with -DSHARED_LIB=ON fails.

Diff Detail

Event Timeline

aheejin created this revision.Jun 18 2018, 3:14 PM
Herald added subscribers: llvm-commits, rogfer01, rkruppe and 3 others. · View Herald TranscriptJun 18 2018, 3:14 PM
Harbormaster completed remote builds in B19440: Diff 151804.Jun 18 2018, 3:14 PM
dcaballe added a subscriber: dcaballe.Jun 18 2018, 3:28 PM
dschuff accepted this revision.Jun 18 2018, 4:50 PM
dschuff added a subscriber: dschuff.

Since it fixes the build and is a trivial change, I think you should just go ahead and commit this.

This revision is now accepted and ready to land.Jun 18 2018, 4:50 PM
Closed by commit rL334997: [VPlan] Add Analysis and Core to LLVM_LINK_COMPONENTS (authored by aheejin). · Explain WhyJun 18 2018, 4:55 PM
This revision was automatically updated to reflect the committed changes.
fhahn added a comment.Jun 18 2018, 11:46 PM

Great, thank you very much for fixing this!!

Revision Contents

PathSize
unittests/
Transforms/
Vectorize/
2 lines

Diff 151804

unittests/Transforms/Vectorize/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Analysis
Core
Vectorize Vectorize
AsmParser AsmParser
) )
add_llvm_unittest(VectorizeTests add_llvm_unittest(VectorizeTests
VPlanTest.cpp VPlanTest.cpp
VPlanHCFGTest.cpp VPlanHCFGTest.cpp
) )