This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Asm: Fix predicate pattern diagnostics.
ClosedPublic

Authored by sdesmalen on Jun 15 2018, 8:03 AM.

Details

Summary

This patch uses the DiagnosticPredicate for SVE predicate patterns
to improve their diagnostics, now giving a 'invalid operand' diagnostic
if the type is not an immediate or one of the expected pattern
labels.

Diff Detail

Repository
rL LLVM

Event Timeline

sdesmalen created this revision.Jun 15 2018, 8:03 AM
fhahn accepted this revision.Jun 15 2018, 8:13 AM
fhahn added a subscriber: fhahn.

LGTM, this fixes some surprising error messages, where invalid predicate pattern was emitted for invalid operands (that are a valid predicate pattern, just not for this instruction or register operands). Thanks Sam for pointing that out in D47716

This revision is now accepted and ready to land.Jun 15 2018, 8:13 AM
This revision was automatically updated to reflect the committed changes.