Page MenuHomePhabricator

[Power9] Update fp128 as a valid homogenous aggregate base type

Authored by lei on Jun 11 2018, 12:01 PM.

Diff Detail


Event Timeline

lei created this revision.Jun 11 2018, 12:01 PM
lei updated this revision to Diff 150821.Jun 11 2018, 1:15 PM
nemanjai accepted this revision.Jul 4 2018, 7:31 AM

Other than a few style nits that can be fixed on the commit, this LGTM.

1802 ↗(On Diff #150821)

// IEEE 754 binary128

4609 ↗(On Diff #150821)

This comment should probably be updated.

4633 ↗(On Diff #150821)

This expression looks very messy, I think it's probably better to rewrite it as multiple expressions or an if statement.

19 ↗(On Diff #150821)

Is it still a homogeneous aggregate if it's nested?
i.e. struct fp10 { struct fp2 a, struct fp3 b };

And if so, should we add that to the test?

This revision is now accepted and ready to land.Jul 4 2018, 7:31 AM
This revision was automatically updated to reflect the committed changes.