This is an archive of the discontinued LLVM Phabricator instance.

Check for process_vm_readv using CheckSymbolExists
ClosedPublic

Authored by xiaobai on Jun 7 2018, 11:36 AM.

Details

Summary

Instead of checking if code compiles, I think it is a better to check
if the symbol exists. This is simpler and should do the same thing.

Diff Detail

Repository
rL LLVM

Event Timeline

xiaobai created this revision.Jun 7 2018, 11:36 AM
compnerd accepted this revision.Jun 7 2018, 12:56 PM
compnerd added a subscriber: compnerd.

This should be functionally identical and is much cleaner. Thanks!

This revision is now accepted and ready to land.Jun 7 2018, 12:56 PM
This revision was automatically updated to reflect the committed changes.