This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Tighten up directives tests
ClosedPublic

Authored by bogden on Jun 7 2018, 4:20 AM.

Details

Summary

Move expected-fail cases from directive-cpu.s to
directive-cpu-err.s. This allows us to remove the 'not' from the
llvm-mc invocation in directive-cpu.s so that this test will fail
in unexpected error cases. It also means that we are not relying
on all stderr coming before any stdout, which seems fragile.

Also make use of CHECK-NEXT to ensure that multiline error messages
really are occuring together.

Diff Detail

Event Timeline

bogden created this revision.Jun 7 2018, 4:20 AM
compnerd accepted this revision.Jun 12 2018, 4:22 PM

Nice cleanup! Thanks for doing this

This revision is now accepted and ready to land.Jun 12 2018, 4:22 PM
bogden updated this revision to Diff 152258.Jun 21 2018, 5:15 AM

Add test that arch is not an acceptable cpu extension, as requested by fhahn

fhahn accepted this revision.Jun 21 2018, 5:21 AM
fhahn added a subscriber: fhahn.

LGTM thanks.

This revision was automatically updated to reflect the committed changes.