[CMake] Filter out -z,defs when building custom libc++

[phosek]

Summary

-z,defs is incompatible with sanitizers so we need to filter it out
from the linker flags before passing them to the libc++ build.

[phosek]

This should unbreak sanitizer builder which is currently red due to my previous change.

[morehouse]

The buildbot is still broken from r334139: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux?numbuilds=200.

The CMake logs show errors like:

/b/sanitizer-x86_64-linux/build/clang_build/./bin/clang++     -fPIC -fvisibility-inlines-hidden -Werror=date-time 
-std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedant
ic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-secti
ons -Wall -std=c++11 -Wno-unused-parameter -fsanitize=memory -fsanitize-memory-track-origins -Wno-pedantic -m64 -D
LIBCXX_HAS_WX_FLAG  -nodefaultlibs -fno-sanitize=all   /WX -o CMakeFiles/cmTC_d4484.dir/src.cxx.o -c /b/sanitizer-
x86_64-linux/build/clang_build/projects/compiler-rt/lib/msan/libcxx_msan_x86_64-bins/CMakeFiles/CMakeTmp/src.cxx
clang-7: error: no such file or directory: '/WX'
--
/b/sanitizer-x86_64-linux/build/clang_build/./bin/clang++     -fPIC -fvisibility-inlines-hidden -Werror=date-time 
-std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedant
ic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-secti
ons -Wall -std=c++11 -Wno-unused-parameter -fsanitize=memory -fsanitize-memory-track-origins -Wno-pedantic -m64 -D
LIBCXX_HAS_NO_WX_FLAG  -nodefaultlibs -fno-sanitize=all   /WX- -o CMakeFiles/cmTC_28ac4.dir/src.cxx.o -c /b/saniti
zer-x86_64-linux/build/clang_build/projects/compiler-rt/lib/msan/libcxx_msan_x86_64-bins/CMakeFiles/CMakeTmp/src.c
xx
clang-7: error: no such file or directory: '/WX-'
--
/b/sanitizer-x86_64-linux/build/clang_build/./bin/clang++     -fPIC -fvisibility-inlines-hidden -Werror=date-time 
-std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedant
ic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-secti
ons -Wall -std=c++11 -Wno-unused-parameter -fsanitize=memory -fsanitize-memory-track-origins -Wno-pedantic -m64 -D
LIBCXX_HAS_EHSC_FLAG  -nodefaultlibs -fno-sanitize=all   /EHsc -o CMakeFiles/cmTC_7d79b.dir/src.cxx.o -c /b/saniti
zer-x86_64-linux/build/clang_build/projects/compiler-rt/lib/msan/libcxx_msan_x86_64-bins/CMakeFiles/CMakeTmp/src.c
xx
clang-7: error: no such file or directory: '/EHsc'

[morehouse]

https://reviews.llvm.org/rCRT334458 should fix the build bot.

[morehouse]

In D47865#1129155, @morehouse wrote:

https://reviews.llvm.org/rCRT334458 should fix the build bot.

Partially fixes. During standalone compiler-rt build we still get:

Performing C++ SOURCE FILE Test LIBCXX_SUPPORTS_STD_EQ_CXX11_FLAG failed with the following output:
Change Dir: /b/sanitizer-x86_64-linux/build/compiler_rt_build/lib/fuzzer/libcxx_fuzzer_x86_64-bins/CMakeFiles/CMakeTmp
Run Build Command:"/usr/bin/make" "cmTC_08c90/fast"
make[3]: Entering directory '/b/sanitizer-x86_64-linux/build/compiler_rt_build/lib/fuzzer/libcxx_fuzzer_x86_64-bins/CMakeFiles/CMakeTmp'
/usr/bin/make -f CMakeFiles/cmTC_08c90.dir/build.make CMakeFiles/cmTC_08c90.dir/build
make[4]: Entering directory '/b/sanitizer-x86_64-linux/build/compiler_rt_build/lib/fuzzer/libcxx_fuzzer_x86_64-bins/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_08c90.dir/src.cxx.o
/b/sanitizer-x86_64-linux/build/llvm_build64/bin/clang++     -Wall -Werror -std=c++11 -Wno-unused-parameter -m64 -D_LIBCPP_ABI_VERSION=Fuzzer -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS=1 -fvisibility=hidden -DLIBCXX_SUPPORTS_STD_EQ_CXX11_FLAG  -nodefaultlibs   -std=c++11 -o CMakeFiles/cmTC_08c90.dir/src.cxx.o -c /b/sanitizer-x8
6_64-linux/build/compiler_rt_build/lib/fuzzer/libcxx_fuzzer_x86_64-bins/CMakeFiles/CMakeTmp/src.cxx
Linking CXX executable cmTC_08c90
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_08c90.dir/link.txt --verbose=1
/b/sanitizer-x86_64-linux/build/llvm_build64/bin/clang++    -Wall -Werror -std=c++11 -Wno-unused-parameter -m64 -D_LIBCPP_ABI_VERSION=Fuzzer -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS=1 -fvisibility=hidden -DLIBCXX_SUPPORTS_STD_EQ_CXX11_FLAG  -nodefaultlibs    CMakeFiles/cmTC_08c90.dir/src.cxx.o  -o cmTC_08c90 -lgcc_s 
/usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../x86_64-linux-gnu/crt1.o:function _start: **error: undefined reference to '__libc_csu_fini'
/usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../x86_64-linux-gnu/crt1.o:function _start: error: undefined reference to '__libc_csu_init'
/usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../x86_64-linux-gnu/crt1.o:function _start: error: undefined reference to '__libc_start_main'
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

[morehouse]

Reverted in https://reviews.llvm.org/rCRT334528.

compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake

add_custom_command(
     )
 
   add_custom_target(${name}-clobber
     DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${name}-clobber-stamp)
 
   set(PASSTHROUGH_VARIABLES
     CMAKE_C_COMPILER_TARGET
     CMAKE_CXX_COMPILER_TARGET
-    CMAKE_SHARED_LINKER_FLAGS
-    CMAKE_MODULE_LINKER_FLAGS
-    CMAKE_EXE_LINKER_FLAGS
     CMAKE_INSTALL_PREFIX
     CMAKE_MAKE_PROGRAM
     CMAKE_LINKER
     CMAKE_AR
     CMAKE_RANLIB
     CMAKE_NM
     CMAKE_OBJCOPY
     CMAKE_OBJDUMP
     CMAKE_STRIP
     CMAKE_SYSROOT
     CMAKE_SYSTEM_NAME)
   foreach(variable ${PASSTHROUGH_VARIABLES})
     if(${variable})
       list(APPEND CMAKE_PASSTHROUGH_VARIABLES -D${variable}=${${variable}})
     endif()
   endforeach()
 
   string(REPLACE ";" " " FLAGS_STRING "${LIBCXX_CFLAGS}")
   set(LIBCXX_C_FLAGS "${CMAKE_C_FLAGS} ${FLAGS_STRING}")
   set(LIBCXX_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${FLAGS_STRING}")
 
+  string(REPLACE "-Wl,-z,defs" "" LIBCXX_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}")
+  string(REPLACE "-Wl,-z,defs" "" LIBCXX_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS}")
+  string(REPLACE "-Wl,-z,defs" "" LIBCXX_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}")
+
   ExternalProject_Add(${name}
     DEPENDS ${name}-clobber ${LIBCXX_DEPS}
     PREFIX ${prefix}
     SOURCE_DIR ${COMPILER_RT_LIBCXX_PATH}
     STAMP_DIR ${STAMP_DIR}
     BINARY_DIR ${BINARY_DIR}
     CMAKE_ARGS ${CMAKE_PASSTHROUGH_VARIABLES}
                ${compiler_args}
                -DCMAKE_C_FLAGS=${LIBCXX_C_FLAGS}
                -DCMAKE_CXX_FLAGS=${LIBCXX_CXX_FLAGS}
+               -DCMAKE_SHARED_LINKER_FLAGS=${LIBCXX_SHARED_LINKER_FLAGS}
+               -DCMAKE_MODULE_LINKER_FLAGS=${LIBCXX_MODULE_LINKER_FLAGS}
+               -DCMAKE_EXE_LINKER_FLAGS=${LIBCXX_EXE_LINKER_FLAGS}
                -DCMAKE_BUILD_TYPE=Release
                -DLLVM_PATH=${LLVM_MAIN_SRC_DIR}
                -DLLVM_BINARY_DIR=${prefix}
                -DLLVM_LIBRARY_OUTPUT_INTDIR=${prefix}/lib
                -DLIBCXX_STANDALONE_BUILD=ON
                ${LIBCXX_CMAKE_ARGS}
     INSTALL_COMMAND ""
     STEP_TARGETS configure build