Page MenuHomePhabricator

[python] Fix most Python binding unittests on Windows
ClosedPublic

Authored by ethanhs on Jun 6 2018, 9:29 PM.

Details

Summary

This fixes all but one of the test cases for Windows. TestCDB will
take more work to debug, as CompilationDatabase seems not to work correctly.

Diff Detail

Repository
rL LLVM

Event Timeline

ethanhs created this revision.Jun 6 2018, 9:29 PM
bkramer accepted this revision.Jun 7 2018, 6:48 AM

I don't know much about the python bindings, but this is probably fine.

This revision is now accepted and ready to land.Jun 7 2018, 6:48 AM
bkramer added a reviewer: jbcoe.

I don't know much about the python bindings, but this is probably fine.

Yeah I wasn't really sure who to add so I looked at the commit history. Thank you for adding the right people.

jbcoe accepted this revision.Jun 7 2018, 12:46 PM

Would you like me to commit this for you?

Would you like me to commit this for you?

Sure, that would be great! I don't have commit rights so I was waiting for someone to do it. Thanks!

This revision was automatically updated to reflect the committed changes.