Page MenuHomePhabricator

wanders (Anders Waldenborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 12 2013, 1:55 AM (411 w, 6 d)

Recent Activity

Jun 9 2021

wanders added a comment to D101139: Create install targets for scan-build-py..

I think this looks good. I can't vouch for the cmake changes.

Jun 9 2021, 7:46 AM · Restricted Project

May 13 2021

wanders added a comment to D101139: Create install targets for scan-build-py..

Renamed lib to libexec and add custom rules to copy files to build output.

May 13 2021, 4:18 AM · Restricted Project

May 3 2021

wanders added inline comments to D101139: Create install targets for scan-build-py..
May 3 2021, 7:12 AM · Restricted Project

Jul 20 2020

wanders committed rG52ab7aa0ba5a: [clang-format] Add BitFieldColonSpacing option (authored by wanders).
[clang-format] Add BitFieldColonSpacing option
Jul 20 2020, 9:17 PM
wanders closed D84090: [clang-format] Add BitFieldColonSpacing option.
Jul 20 2020, 9:17 PM · Restricted Project, Restricted Project
wanders added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.
  1. then I can do git clang-format, this will fix up any files in the diff that need formatting (you'll need to git add them again if they have)
Jul 20 2020, 9:32 AM · Restricted Project, Restricted Project
wanders updated the diff for D84090: [clang-format] Add BitFieldColonSpacing option.
Jul 20 2020, 9:28 AM · Restricted Project, Restricted Project
wanders updated the diff for D84090: [clang-format] Add BitFieldColonSpacing option.

Renamed option to "BitFieldColonSpacing" and made it an enum of: "Both", "None," "Before", "After"

Jul 20 2020, 7:43 AM · Restricted Project, Restricted Project

Jul 18 2020

wanders added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

The changes look good to me in general. I share your doubt though about whether a bool flag is sufficient here. We've seen in the past a few times that at some time a false/true flag is not enough. I'd rather go for a Before/After/Both/None flag (or similar, naming probably should be coherent with other flags). But I'm not really aware of the projects/coding styles that use bit fields. Maybe a small research on this would be good to confirm or infirm a necessity of higher complexity.

Jul 18 2020, 1:59 PM · Restricted Project, Restricted Project
wanders updated the diff for D84090: [clang-format] Add BitFieldColonSpacing option.
  • Regenerated rst
  • Fixed clang format errors
  • Added release note
  • Added bool parsing test
Jul 18 2020, 9:26 AM · Restricted Project, Restricted Project
wanders committed rG6d7ec54170f9: [clang-format] Make sure rst documentation matches comments (authored by wanders).
[clang-format] Make sure rst documentation matches comments
Jul 18 2020, 9:03 AM
wanders closed D84103: [clang-format] Make sure rst documentation matches comments.
Jul 18 2020, 9:03 AM · Restricted Project, Restricted Project
Herald added a project to D84103: [clang-format] Make sure rst documentation matches comments: Restricted Project.
Jul 18 2020, 8:53 AM · Restricted Project, Restricted Project
Herald added a project to D84090: [clang-format] Add BitFieldColonSpacing option: Restricted Project.
Jul 18 2020, 3:54 AM · Restricted Project, Restricted Project

May 8 2020

wanders abandoned D68569: [clang-format] Also look for .{ext}.clang-format file.

Can we abandon this review now we have the style=file:<filename>?

May 8 2020, 2:06 AM · Restricted Project, Restricted Project

Nov 7 2019

wanders committed rG86825dbe3306: [clang-format] Make '.clang-format' variants finding a loop (NFC) (authored by wanders).
[clang-format] Make '.clang-format' variants finding a loop (NFC)
Nov 7 2019, 1:09 AM
wanders closed D68568: [clang-format] Make '.clang-format' variants finding a loop.
Nov 7 2019, 1:09 AM · Restricted Project, Restricted Project

Nov 6 2019

wanders added a comment to D68568: [clang-format] Make '.clang-format' variants finding a loop.

Do you need help landing this?

Nov 6 2019, 1:34 PM · Restricted Project, Restricted Project

Oct 7 2019

wanders added a comment to D68569: [clang-format] Also look for .{ext}.clang-format file.

The "Language" option can not distinguish between C and C++.

Oct 7 2019, 5:01 AM · Restricted Project, Restricted Project
wanders added reviewers for D68569: [clang-format] Also look for .{ext}.clang-format file: MyDeveloperDay, klimek, owenpan.
Oct 7 2019, 4:13 AM · Restricted Project, Restricted Project
wanders added reviewers for D68568: [clang-format] Make '.clang-format' variants finding a loop: MyDeveloperDay, klimek, owenpan.
Oct 7 2019, 4:13 AM · Restricted Project, Restricted Project
wanders added a comment to D68569: [clang-format] Also look for .{ext}.clang-format file.

This depends on https://reviews.llvm.org/D68568

Oct 7 2019, 4:10 AM · Restricted Project, Restricted Project
wanders created D68569: [clang-format] Also look for .{ext}.clang-format file.
Oct 7 2019, 4:10 AM · Restricted Project, Restricted Project
wanders created D68568: [clang-format] Make '.clang-format' variants finding a loop.
Oct 7 2019, 4:09 AM · Restricted Project, Restricted Project
wanders abandoned D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone.

I might revisit this later. But carrying this patch locally for now.

Oct 7 2019, 3:53 AM · Restricted Project

May 10 2019

wanders added a comment to D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone.

Why are you interested in expending this list?

May 10 2019, 5:11 AM · Restricted Project

May 7 2019

wanders added a comment to D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone.

But running code that has been compiled with -mno-red-zone on a platform that guarantees that redzones are not stamped on should be fine as far as I can understand?

May 7 2019, 11:19 AM · Restricted Project

May 6 2019

wanders created D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone.
May 6 2019, 11:11 PM · Restricted Project
wanders committed rG09b91a2696b5: [llvm-c-test] Make include-all.c do what its name says it does (authored by wanders).
[llvm-c-test] Make include-all.c do what its name says it does
May 6 2019, 4:31 AM

May 5 2019

wanders committed rG4732d3abdf07: [llvm-c] Make LLVMGetStringErrorTypeId a proper prototype (authored by wanders).
[llvm-c] Make LLVMGetStringErrorTypeId a proper prototype
May 5 2019, 11:42 PM
wanders added a reviewer for D61568: [llvm-c] Make LLVMGetStringErrorTypeId a proper prototype: whitequark.
May 5 2019, 8:16 AM · Restricted Project
wanders added reviewers for D61567: [llvm-c-test] Make include-all.c do what its name says it does: whitequark, deadalnix.
May 5 2019, 7:05 AM · Restricted Project
wanders added a comment to D61567: [llvm-c-test] Make include-all.c do what its name says it does.

https://reviews.llvm.org/D61568 will be committed before this.

May 5 2019, 7:05 AM · Restricted Project
wanders created D61568: [llvm-c] Make LLVMGetStringErrorTypeId a proper prototype.
May 5 2019, 6:59 AM · Restricted Project
wanders created D61567: [llvm-c-test] Make include-all.c do what its name says it does.
May 5 2019, 6:49 AM · Restricted Project

May 19 2015

wanders added a comment to D9835: clang-format: Add space in function pointers with SpaceBeforeParens=Always.

Looks good. Do you have commit access?

May 19 2015, 2:04 AM

May 18 2015

wanders retitled D9835: clang-format: Add space in function pointers with SpaceBeforeParens=Always from to clang-format: Add space in function pointers with SpaceBeforeParens=Always.
May 18 2015, 1:50 PM

Apr 13 2015

wanders updated the diff for D9008: Fix crash in DebugInfoFinder when adding a module with forward declared composite type..
Apr 13 2015, 3:22 PM
wanders retitled D9008: Fix crash in DebugInfoFinder when adding a module with forward declared composite type. from to Fix crash in DebugInfoFinder when adding a module with forward declared composite type..
Apr 13 2015, 2:45 PM

Jun 24 2014

wanders added a comment to D4236: Expose MCInst in C Disassembler API.

I would find this to be a useful addition the the API. Especially if it could be extended with a function like LLVMMCInstIsFlowControl

Jun 24 2014, 1:57 AM

May 19 2014

wanders closed D3474: [python] Fix getting section contents. .

Closed by commit rL207199 (authored by andersg).

May 19 2014, 7:23 AM
wanders closed D3334: llvm-build: Get rid of 'import *'.

Closed by commit rL207012 (authored by andersg).

May 19 2014, 7:23 AM

Apr 23 2014

wanders retitled D3474: [python] Fix getting section contents. from to [python] Fix getting section contents. .
Apr 23 2014, 1:43 PM