Page MenuHomePhabricator

ethanhs (Ethan)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 13 2016, 5:21 PM (165 w, 1 d)

Recent Activity

Feb 12 2019

Herald updated subscribers of D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 12 2019, 1:59 AM

Jun 21 2018

ethanhs added a comment to D47864: [python] Fix most Python binding unittests on Windows.

Would you like me to commit this for you?

Jun 21 2018, 12:24 PM

Jun 13 2018

ethanhs accepted D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.

Works great!

Jun 13 2018, 2:25 AM

Jun 12 2018

ethanhs added a comment to D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.
In D47672#1128863, @rnk wrote:

It sounds like adding proper support for HLE prefixes is a largeish project.

ctopper, rnk: Do you think it would be worth adding inline asm versions (with the xacquire/release prefixes) of these intrinsics in the meantime? It would inhibit optimizations but be better than the current state of not having the intrinsics at all.

Yeah, let's do that. I'm a lot more comfortable ignoring bugs about missed optimizations with fancy intrinsics than bugs that say the intrinsic doesn't do what it says it does.

Jun 12 2018, 4:09 PM

Jun 7 2018

ethanhs added a comment to D47864: [python] Fix most Python binding unittests on Windows.

I don't know much about the python bindings, but this is probably fine.

Jun 7 2018, 12:17 PM

Jun 6 2018

ethanhs created D47864: [python] Fix most Python binding unittests on Windows.
Jun 6 2018, 9:30 PM
ethanhs added inline comments to D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.
Jun 6 2018, 1:16 PM
ethanhs updated the diff for D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.

Guard to be used only under MSVC, define default FN attrs

Jun 6 2018, 1:03 PM
ethanhs added a comment to D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.

We (Intel) have discussed this a little internally. I'll be responding more shortly.

Jun 6 2018, 12:27 PM

Jun 5 2018

ethanhs added a comment to D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.
In D47672#1121181, @rnk wrote:
Jun 5 2018, 1:09 AM

Jun 3 2018

ethanhs updated the summary of D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.
Jun 3 2018, 9:35 PM

Jun 1 2018

ethanhs updated the summary of D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.
Jun 1 2018, 10:59 PM
ethanhs created D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.
Jun 1 2018, 10:56 PM