The index doesn't actually return results in ranked order.
Details
Diff Detail
- Repository
- rCTE Clang Tools Extra
- Build Status
Buildable 18987 Build 18987: arc lint + arc unit
Event Timeline
LGTM.
clangd/FindSymbols.cpp | ||
---|---|---|
159 | Should we add a log statement here? IMO, this rarely happens? If it happens, it means that the fuzzy matcher algorithms used by index and clangd side have disagreement. |
This works much better! Just a nit.
clangd/FindSymbols.cpp | ||
---|---|---|
20 | nit: I don't think this is used. Remove? |
clangd/FindSymbols.cpp | ||
---|---|---|
20 | This is consumed by the LLVM_DEBUG macro. You can enable program-wide debug output with -debug, but much more useful is -debug-only=somestring which will only enable LLVM_DEBUG sections in files with the matching DEBUG_TYPE. So here if you get mysterious ranking of workspace/symbol results, you can run clangd with -debug-only=FindSymbols and get the signals and component scores dumped to stderr. |
nit: I don't think this is used. Remove?