This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Fix .td files after rL333900
ClosedPublic

Authored by sbc100 on Jun 4 2018, 9:52 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jun 4 2018, 9:52 AM

Not really sure what is going on here, but copying similar changes from breaking CL seems to fix

dschuff accepted this revision.Jun 4 2018, 9:58 AM
This revision is now accepted and ready to land.Jun 4 2018, 9:58 AM
This revision was automatically updated to reflect the committed changes.

My apologies. I thought I was testing all targets, but clearly I wasn't, and I didn't see buildbot failures.

The background is that defm and defm "" now both have well-defined but different meanings. The TableGen/LangRef.rst says this as well, but the summary is:

  1. defm "" behaves like any other defm, concatenating names by default, just with an empty concatenation.
  2. defm without a name generates a new, globally unique name and uses that (the name takes the form of "anonymous_NNNN" right now, but that's an implementation detail).

Previously, defm would sometimes behave like it does now, and sometimes like defm "" behaves now, and which behavior it actually took depended on a spooky-action-at-a-distance rule that never really made sense to begin with (it clearly just grew historically).

Again, my apologies for the inconvenience.

No worries; the WebAssembly target is still an "experimental" target and doesn't build by default (even you build "all" targets) unless you also add -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD. So this happens from time to time.