Page MenuHomePhabricator

[Analyzer] Fix the Z3 lit test config
ClosedPublic

Authored by vlad.tsyrklevich on Jun 4 2018, 8:53 AM.

Details

Summary

The '%analyze' extra_args config argument seems to have been erroneously
deleted in r315627 disabling Z3 tests for the clang analyzer. Add the
flag back.

Diff Detail

Repository
rL LLVM

Event Timeline

george.karpenkov accepted this revision.Jun 4 2018, 12:05 PM

LGTM, but could you clarify what was disabled? Tests for the Z3 solver as done by @ddcc ?

Also, I trust that all tests still pass?

This revision is now accepted and ready to land.Jun 4 2018, 12:05 PM

LGTM, but could you clarify what was disabled? Tests for the Z3 solver as done by @ddcc ?

llvm-lit would run all analyzer tests (at least those using RUN: %clang_analyzer_cc1) twice when Z3 was enabled, once with and without Z3. It did so by substituting %analyze for the Z3 CM params, so when %analyze was removed llvm-lit just ran tests twice with the range CM http://llvm-cs.pcc.me.uk/tools/clang/test/Analysis/analyzer_test.py#38

Also, I trust that all tests still pass?

Almost, the fix-ups were submitted in https://reviews.llvm.org/D47726

llvm-lit would run all analyzer tests (at least those using RUN: %clang_analyzer_cc1) twice when Z3 was enabled, once with and without Z3

Right, and that sounds like a bad idea, because you might have Z3 configured, but at the same time you might not want to run every test with it every time.
I think there should be a separate target.

This revision was automatically updated to reflect the committed changes.