Page MenuHomePhabricator

[Mips] Remove uneeded variants of ADDC/ADDE lowering
ClosedPublic

Authored by deadalnix on Jun 4 2018, 3:43 AM.

Details

Summary

As it turns out, the lowering for the Mips16* family of target is the exact same thing as what the ops expands to, so the code handling them can be removed and the ops only enabled for the MipsSE* family of targets.

Diff Detail

Repository
rL LLVM

Event Timeline

deadalnix created this revision.Jun 4 2018, 3:43 AM
sdardis added inline comments.Jun 4 2018, 4:46 AM
lib/Target/Mips/MipsSEISelLowering.cpp
108 ↗(On Diff #149706)

This needs to be Subtarget.hasDSP() && Subtarget.hasMips32r2().

deadalnix added inline comments.Jun 4 2018, 8:14 AM
lib/Target/Mips/MipsSEISelLowering.cpp
85 ↗(On Diff #149706)

Here.

108 ↗(On Diff #149706)

This is what it is doing, see the if around the whole section.

sdardis accepted this revision.Jun 5 2018, 7:59 AM
sdardis added inline comments.
lib/Target/Mips/MipsSEISelLowering.cpp
108 ↗(On Diff #149706)

D'oh. Missed that.

This revision is now accepted and ready to land.Jun 5 2018, 7:59 AM
This revision was automatically updated to reflect the committed changes.