Page MenuHomePhabricator

smaksimovic (Stefan Maksimovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 5:19 AM (131 w, 3 d)

Recent Activity

Apr 8 2019

smaksimovic abandoned D35985: Skip live range segment verification for reserved physregs.

Understood, glad to see it finally resolved.

Apr 8 2019, 7:37 AM

Nov 5 2018

smaksimovic committed rL346133: [Mips] Supplement long branch pseudo instructions.
[Mips] Supplement long branch pseudo instructions
Nov 5 2018, 6:40 AM
smaksimovic closed D53977: [Mips] Supplement long branch pseudo instructions.
Nov 5 2018, 6:40 AM

Nov 2 2018

smaksimovic accepted D53861: [mips] Support sigrie instruction.

LGTM

Nov 2 2018, 1:12 AM

Nov 1 2018

smaksimovic created D53977: [Mips] Supplement long branch pseudo instructions.
Nov 1 2018, 8:11 AM
smaksimovic committed rL345821: [Mips] Conditionally remove successor block.
[Mips] Conditionally remove successor block
Nov 1 2018, 3:13 AM
smaksimovic closed D53756: [Mips] Conditionally remove successor block.
Nov 1 2018, 3:13 AM

Oct 26 2018

smaksimovic created D53756: [Mips] Conditionally remove successor block.
Oct 26 2018, 5:56 AM

Oct 12 2018

smaksimovic committed rL344326: [mips] Mark fmaxl as a long double emulation routine.
[mips] Mark fmaxl as a long double emulation routine
Oct 12 2018, 1:21 AM
smaksimovic closed D52649: [mips] Mark fmaxl as a long double emulation routine.
Oct 12 2018, 1:21 AM

Oct 11 2018

smaksimovic added a comment to D52649: [mips] Mark fmaxl as a long double emulation routine.

In that case I'll commit this patch, the issue with float routine names being kept in the MIPS backend can be deferred to a separate patch since it does not pertain to fmaxl only.

Oct 11 2018, 8:33 AM

Oct 10 2018

smaksimovic added a comment to D52649: [mips] Mark fmaxl as a long double emulation routine.

My only goal was to correct the return value of fmaxl to be interpreted as a 128bit float.
As it stands the return value is being interpreted as an i128 and fetched from the wrong registers.

Oct 10 2018, 4:26 AM

Oct 8 2018

smaksimovic accepted D52876: [mips] Fix FDE/CFI encoding in case of N32 ABI.

LGTM

Oct 8 2018, 7:58 AM
smaksimovic accepted D52874: [mips] Set pointer size to 4 bytes for N32 ABI.

LGTM

Oct 8 2018, 7:57 AM

Sep 28 2018

smaksimovic created D52649: [mips] Mark fmaxl as a long double emulation routine.
Sep 28 2018, 7:22 AM

Sep 24 2018

smaksimovic committed rL342946: [mips] Correct MUL pattern for mips64.
[mips] Correct MUL pattern for mips64
Sep 24 2018, 11:29 PM
smaksimovic closed D51684: [mips] Correct MUL pattern for mips64.
Sep 24 2018, 11:29 PM

Sep 5 2018

smaksimovic created D51684: [mips] Correct MUL pattern for mips64.
Sep 5 2018, 7:32 AM

Sep 3 2018

smaksimovic accepted D51483: [mips] Disable the selection of mixed microMIPS/MIPS code.

LGTM

Sep 3 2018, 4:15 AM

Aug 31 2018

smaksimovic added a comment to D51483: [mips] Disable the selection of mixed microMIPS/MIPS code.

It seems that I cannot apply this patch without applying D51482 first, because that patch introduces the test file.
They should be either decoupled or made dependent on phabricator to indicate the relation.

Aug 31 2018, 7:18 AM
smaksimovic accepted D51482: [mips] Fix `mtc1` and `mfc1` definitions for microMIPS R6.

LGTM

Aug 31 2018, 7:12 AM

Aug 24 2018

smaksimovic accepted D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.

LGTM

Aug 24 2018, 2:01 AM

Aug 22 2018

smaksimovic committed rL340392: [mips] Handle missing CondCodes.
[mips] Handle missing CondCodes
Aug 22 2018, 2:35 AM
smaksimovic closed D50757: [mips] Handle missing CondCodes.
Aug 22 2018, 2:35 AM
smaksimovic committed rL340391: [clang][mips] Set __mips_fpr correctly for -mfpxx.
[clang][mips] Set __mips_fpr correctly for -mfpxx
Aug 22 2018, 2:27 AM
smaksimovic committed rC340391: [clang][mips] Set __mips_fpr correctly for -mfpxx.
[clang][mips] Set __mips_fpr correctly for -mfpxx
Aug 22 2018, 2:27 AM
smaksimovic closed D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx.
Aug 22 2018, 2:27 AM

Aug 21 2018

smaksimovic updated the diff for D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx.

Expanded a piece of code using switch cases as suggested.

Aug 21 2018, 4:09 AM
smaksimovic added inline comments to D50757: [mips] Handle missing CondCodes.
Aug 21 2018, 2:22 AM
smaksimovic updated the diff for D50757: [mips] Handle missing CondCodes.

Update test file to cover all of the patterns included in the change.

Aug 21 2018, 2:21 AM

Aug 17 2018

smaksimovic added inline comments to D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx.
Aug 17 2018, 6:56 AM
smaksimovic updated the diff for D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx.

Added test cases.

Aug 17 2018, 6:52 AM

Aug 16 2018

smaksimovic committed rUNW339878: [libunwind][mips] Include gcc_s for linkage.
[libunwind][mips] Include gcc_s for linkage
Aug 16 2018, 6:41 AM
smaksimovic committed rL339878: [libunwind][mips] Include gcc_s for linkage.
[libunwind][mips] Include gcc_s for linkage
Aug 16 2018, 6:41 AM
smaksimovic closed D50243: [libunwind][mips] Include gcc_s for linkage.
Aug 16 2018, 6:41 AM
smaksimovic added a comment to D50243: [libunwind][mips] Include gcc_s for linkage.

@joerg Would it be okay to commit this?
The LIBUNWIND_HAS_GCC_S_LIB although declared, did not have its value used anywhere unlike LIBUNWIND_HAS_C_LIB and LIBUNWIND_HAS_DL_LIB which had been declared/used similarly.
The added line is only executed if the following block is (cmake/config-ix.cmake):

if (NOT LIBUNWIND_USE_COMPILER_RT)
  check_library_exists(gcc_s __gcc_personality_v0 "" LIBUNWIND_HAS_GCC_S_LIB)
endif()

in which case compiler-rt is not being used anyway, if that's what you were referring to.

Aug 16 2018, 2:12 AM
smaksimovic committed rUNW339849: [libunwind][mips] Guard accumulator registers.
[libunwind][mips] Guard accumulator registers
Aug 16 2018, 1:50 AM
smaksimovic committed rUNW339848: [libunwind][mips] Modify the __mips_fpr macro check.
[libunwind][mips] Modify the __mips_fpr macro check
Aug 16 2018, 1:50 AM
smaksimovic committed rL339849: [libunwind][mips] Guard accumulator registers.
[libunwind][mips] Guard accumulator registers
Aug 16 2018, 1:50 AM
smaksimovic closed D50244: [libunwind][mips] Guard accumulator registers.
Aug 16 2018, 1:50 AM
smaksimovic committed rL339848: [libunwind][mips] Modify the __mips_fpr macro check.
[libunwind][mips] Modify the __mips_fpr macro check
Aug 16 2018, 1:48 AM
smaksimovic closed D50245: [libunwind][mips] Modify the __mips_fpr macro check.
Aug 16 2018, 1:48 AM

Aug 15 2018

smaksimovic updated the diff for D50757: [mips] Handle missing CondCodes.

Add test file.

Aug 15 2018, 7:49 AM
smaksimovic created D50757: [mips] Handle missing CondCodes.
Aug 15 2018, 1:54 AM

Aug 10 2018

smaksimovic created D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx.
Aug 10 2018, 4:15 AM

Aug 5 2018

smaksimovic added a reviewer for D50243: [libunwind][mips] Include gcc_s for linkage: compnerd.
Aug 5 2018, 11:39 PM

Aug 3 2018

smaksimovic created D50245: [libunwind][mips] Modify the __mips_fpr macro check.
Aug 3 2018, 5:24 AM
smaksimovic created D50244: [libunwind][mips] Guard accumulator registers.
Aug 3 2018, 5:15 AM
smaksimovic created D50243: [libunwind][mips] Include gcc_s for linkage.
Aug 3 2018, 5:10 AM

Jul 30 2018

smaksimovic committed rC338246: [mips64][clang] Adjust tests to account for changes in r338239.
[mips64][clang] Adjust tests to account for changes in r338239
Jul 30 2018, 5:28 AM
smaksimovic committed rL338246: [mips64][clang] Adjust tests to account for changes in r338239.
[mips64][clang] Adjust tests to account for changes in r338239
Jul 30 2018, 5:28 AM
smaksimovic committed rL338239: [mips64][clang] Provide the signext attribute for i32 return values.
[mips64][clang] Provide the signext attribute for i32 return values
Jul 30 2018, 3:45 AM
smaksimovic committed rC338239: [mips64][clang] Provide the signext attribute for i32 return values.
[mips64][clang] Provide the signext attribute for i32 return values
Jul 30 2018, 3:45 AM
smaksimovic closed D49289: [mips64][clang] Provide the signext attribute for i32 return values.
Jul 30 2018, 3:45 AM

Jul 26 2018

smaksimovic committed rL338019: [mips] Sign extend i32 return values on MIPS64.
[mips] Sign extend i32 return values on MIPS64
Jul 26 2018, 3:59 AM
smaksimovic closed D48374: [mips] Sign extend i32 return values on MIPS64.
Jul 26 2018, 3:59 AM

Jul 24 2018

smaksimovic added a comment to D48374: [mips] Sign extend i32 return values on MIPS64.

Not anymore, I'd like to have it reviewed.
I rolled it back to the version similar to the one you reviewed initially.

Jul 24 2018, 6:15 AM

Jul 20 2018

smaksimovic updated the diff for D48374: [mips] Sign extend i32 return values on MIPS64.

Revert patch back to the previous version.

Jul 20 2018, 2:16 AM

Jul 19 2018

smaksimovic added inline comments to D48374: [mips] Sign extend i32 return values on MIPS64.
Jul 19 2018, 6:50 AM

Jul 18 2018

smaksimovic added inline comments to D48374: [mips] Sign extend i32 return values on MIPS64.
Jul 18 2018, 8:46 AM

Jul 16 2018

smaksimovic requested review of D48374: [mips] Sign extend i32 return values on MIPS64.
Jul 16 2018, 7:33 AM
smaksimovic accepted D48365: [mips] Eliminate the usage of hasStdEnc in MipsPat..

Looks good, no failures this time.

Jul 16 2018, 2:03 AM

Jul 13 2018

smaksimovic created D49289: [mips64][clang] Provide the signext attribute for i32 return values.
Jul 13 2018, 5:05 AM
smaksimovic updated the diff for D48374: [mips] Sign extend i32 return values on MIPS64.

Added target hooks to replace the sign_extend with the sign_extend_inreg node which will get pattern matched with the SLL64_64 thus providing the needed sign extension.
The second target hook is introduced to keep the sign_extend_inreg node from being combined away.

Jul 13 2018, 3:57 AM

Jul 9 2018

smaksimovic committed rL336545: [mips] Addition of the [d]rem and [d]remu instructions.
[mips] Addition of the [d]rem and [d]remu instructions
Jul 9 2018, 6:11 AM
smaksimovic closed D17036: [mips] Addition of the [d]rem and [d]remu instructions.
Jul 9 2018, 6:11 AM

Jul 4 2018

smaksimovic planned changes to D48374: [mips] Sign extend i32 return values on MIPS64.

Forgot to mark this explicitly as still being WIP, since we are missing sign extensions at some places.

Jul 4 2018, 8:30 AM

Jun 20 2018

smaksimovic accepted D48379: [mips] Mark standard encoded instructions as not being in MIPS16e.

LGTM.

Jun 20 2018, 10:27 AM
smaksimovic added a comment to D48365: [mips] Eliminate the usage of hasStdEnc in MipsPat..

There appear to be a couple of test failures for this patch, at least on my end.
I am at r335143.

Jun 20 2018, 9:43 AM
smaksimovic created D48374: [mips] Sign extend i32 return values on MIPS64.
Jun 20 2018, 9:00 AM

Jun 19 2018

smaksimovic accepted D48275: [mips] Add microMIPS specific addressing patterns..

Looks okay, one small remark

Jun 19 2018, 6:26 AM

Jun 15 2018

smaksimovic commandeered D17036: [mips] Addition of the [d]rem and [d]remu instructions.
Jun 15 2018, 8:16 AM

Jun 11 2018

smaksimovic added a comment to D31287: [mips] Fix atomic operations at O0, v3.

@sdardis I hadn't checked myself before posting but as you say that is indeed what clang-format outputs.

Jun 11 2018, 4:19 AM · Restricted Project

Jun 6 2018

smaksimovic accepted D47638: [mips] Correct the predicates for a number of codegen only instructions.

In that case LGTM.

Jun 6 2018, 10:36 AM

Jun 5 2018

smaksimovic added a comment to D47636: [mips] Guard some floating point instructions correctly.

Looks okay, you could add a test case if you feel the change requires it.

Jun 5 2018, 4:25 AM
smaksimovic added a comment to D47638: [mips] Correct the predicates for a number of codegen only instructions.

Looks okay, you could add a test case if you feel the change requires it.

Jun 5 2018, 4:25 AM

Jun 1 2018

smaksimovic accepted D47316: [mips] Support 64-bit offsets for lb/sb/ld/sd/lld ... instructions.

LGTM.

Jun 1 2018, 7:45 AM
smaksimovic accepted D31287: [mips] Fix atomic operations at O0, v3.

LGTM.

Jun 1 2018, 7:22 AM · Restricted Project
smaksimovic added a comment to D31287: [mips] Fix atomic operations at O0, v3.

Mostly comment fix suggestions

Jun 1 2018, 5:46 AM · Restricted Project

May 30 2018

smaksimovic accepted D47526: [mips] Sink PredicateControl further down the class hierarchy..

LGTM.

May 30 2018, 5:09 AM
smaksimovic added a comment to D47526: [mips] Sink PredicateControl further down the class hierarchy..

Looks okay except it seems that other changes have snuck in.
From what I can tell the patch was created before rL333288 got committed.
In addition this patch appears to contain changes from D47075 as well.
Please rebase.

May 30 2018, 4:26 AM

May 29 2018

smaksimovic accepted D47464: [mips] Process numeric register name in the .set assignment directive.

LGTM

May 29 2018, 8:26 AM
smaksimovic accepted D47220: [mips] Emit R_MICROMIPS_GPREL16/R_MICROMIPS_SUB/R_MICROMIPS_LO16 / HI16 relocations.

LGTM

May 29 2018, 4:04 AM
smaksimovic accepted D47219: [mips] Emit R_MICROMIPS_HIGHER / R_MICROMIPS_HIGHEST relocations.

LGTM

May 29 2018, 3:11 AM

May 8 2018

smaksimovic committed rL331771: [mips][msa] Pattern match the splat.d instruction.
[mips][msa] Pattern match the splat.d instruction
May 8 2018, 8:16 AM
smaksimovic closed D45683: [mips][msa] Pattern match the splat.d instruction.
May 8 2018, 8:16 AM

Apr 18 2018

smaksimovic added a comment to D45364: [mips] Update the generic model not to use instruction itineraries.

This looks fine, regarding the instructions introduced instead of their matching itinerary classes.

Apr 18 2018, 5:47 AM

Apr 16 2018

smaksimovic created D45683: [mips][msa] Pattern match the splat.d instruction.
Apr 16 2018, 5:48 AM
smaksimovic committed rL330114: [mips] Restrict certain trap instructions for micromipsr6.
[mips] Restrict certain trap instructions for micromipsr6
Apr 16 2018, 2:25 AM
smaksimovic closed D45318: [mips] Restrict certain trap instructions for micromipsr6.
Apr 16 2018, 2:25 AM

Apr 5 2018

smaksimovic created D45318: [mips] Restrict certain trap instructions for micromipsr6.
Apr 5 2018, 5:59 AM
smaksimovic accepted D45245: [mips] Update the P5600 scheduler model not to use instruction itineraries..

LGTM

Apr 5 2018, 4:15 AM

Apr 4 2018

smaksimovic added a comment to D35985: Skip live range segment verification for reserved physregs.

I would expect the live ranges of register units that are reserved to be empty and therefore naturally pass verification. Do you know why you end up having non-empty information in those live ranges? We should identify the cause for that and fix it.

Apr 4 2018, 6:18 AM

Feb 23 2018

smaksimovic committed rC325899: [mips] Revert r325872.
[mips] Revert r325872
Feb 23 2018, 5:48 AM
smaksimovic committed rL325899: [mips] Revert r325872.
[mips] Revert r325872
Feb 23 2018, 5:48 AM
smaksimovic committed rC325872: [mips] Reland r310704.
[mips] Reland r310704
Feb 23 2018, 12:40 AM
smaksimovic committed rL325872: [mips] Reland r310704.
[mips] Reland r310704
Feb 23 2018, 12:40 AM

Feb 22 2018

smaksimovic committed rL325782: [mips] Generate memory dependencies for byVal arguments.
[mips] Generate memory dependencies for byVal arguments
Feb 22 2018, 5:44 AM
smaksimovic closed D37515: [mips] Generate memory dependencies for byVal arguments.
Feb 22 2018, 5:44 AM
smaksimovic updated the diff for D37515: [mips] Generate memory dependencies for byVal arguments.
Feb 22 2018, 5:33 AM