It's super irritating.
[properly configured] git client then complains about that double-newline,
and you have to use --force to ignore the warning, since even if you
fix it manually, it will be reintroduced the very next runtime :/
Paths
| Differential D47697
[llvm-mca] Make sure not to end the test files with an empty line. ClosedPublic Authored by lebedev.ri on Jun 4 2018, 12:05 AM.
Details Summary It's super irritating. [properly configured] git client then complains about that double-newline,
Diff Detail
Event Timelinelebedev.ri added a child revision: D47676: [X86][Znver1] Specify Register Files, RCU; FP scheduler capacity..Jun 4 2018, 12:23 AM Comment Actions Thanks for the patch! Annoying that my git client never complained about this one to me.
Comment Actions @gbedwell thank you for taking a look.
lebedev.ri marked 3 inline comments as done. Comment ActionsUse new, third variant of writing lines.
This revision is now accepted and ready to land.Jun 4 2018, 4:39 AM Comment Actions
Thank you for the review, and the script! Closed by commit rL333887: [llvm-mca] Make sure not to end the test files with an empty line. (authored by lebedevri). · Explain WhyJun 4 2018, 4:53 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 149677 test/tools/llvm-mca/AArch64/CortexA57/direct-branch.s
test/tools/llvm-mca/AArch64/Exynos/direct-branch.s
test/tools/llvm-mca/AArch64/Exynos/scheduler-queue-usage.s
test/tools/llvm-mca/AArch64/Falkor/zero-latency-store.s
test/tools/llvm-mca/X86/Atom/resources-cmov.s
test/tools/llvm-mca/X86/Atom/resources-mmx.s
test/tools/llvm-mca/X86/Atom/resources-sse1.s
test/tools/llvm-mca/X86/Atom/resources-sse2.s
test/tools/llvm-mca/X86/Atom/resources-sse3.s
test/tools/llvm-mca/X86/Atom/resources-ssse3.s
test/tools/llvm-mca/X86/Atom/resources-x86_64.s
test/tools/llvm-mca/X86/Atom/resources-x87.s
test/tools/llvm-mca/X86/Broadwell/resources-adx.s
test/tools/llvm-mca/X86/Broadwell/resources-avx1.s
test/tools/llvm-mca/X86/Broadwell/resources-avx2.s
test/tools/llvm-mca/X86/Broadwell/resources-bmi1.s
test/tools/llvm-mca/X86/Broadwell/resources-bmi2.s
test/tools/llvm-mca/X86/Broadwell/resources-cmov.s
test/tools/llvm-mca/X86/Broadwell/resources-f16c.s
test/tools/llvm-mca/X86/Broadwell/resources-fma.s
test/tools/llvm-mca/X86/Broadwell/resources-lzcnt.s
test/tools/llvm-mca/X86/Broadwell/resources-mmx.s
test/tools/llvm-mca/X86/Broadwell/resources-popcnt.s
test/tools/llvm-mca/X86/Broadwell/resources-sse1.s
test/tools/llvm-mca/X86/Broadwell/resources-sse2.s
test/tools/llvm-mca/X86/Broadwell/resources-sse3.s
test/tools/llvm-mca/X86/Broadwell/resources-sse41.s
test/tools/llvm-mca/X86/Broadwell/resources-sse42.s
test/tools/llvm-mca/X86/Broadwell/resources-ssse3.s
test/tools/llvm-mca/X86/Broadwell/resources-x86_64.s
test/tools/llvm-mca/X86/Broadwell/resources-x87.s
test/tools/llvm-mca/X86/BtVer2/dot-product.s
test/tools/llvm-mca/X86/BtVer2/hadd-read-after-ld-1.s
test/tools/llvm-mca/X86/BtVer2/hadd-read-after-ld-2.s
test/tools/llvm-mca/X86/BtVer2/instruction-info-view.s
test/tools/llvm-mca/X86/BtVer2/load-store-alias.s
test/tools/llvm-mca/X86/BtVer2/memcpy-like-test.s
test/tools/llvm-mca/X86/BtVer2/pipes-fpu.s
test/tools/llvm-mca/X86/BtVer2/rcu-statistics.s
test/tools/llvm-mca/X86/BtVer2/read-advance-1.s
test/tools/llvm-mca/X86/BtVer2/read-advance-2.s
test/tools/llvm-mca/X86/BtVer2/read-advance-3.s
test/tools/llvm-mca/X86/BtVer2/register-files-1.s
test/tools/llvm-mca/X86/BtVer2/register-files-2.s
test/tools/llvm-mca/X86/BtVer2/register-files-3.s
test/tools/llvm-mca/X86/BtVer2/register-files-4.s
test/tools/llvm-mca/X86/BtVer2/register-files-5.s
test/tools/llvm-mca/X86/BtVer2/resources-aes.s
test/tools/llvm-mca/X86/BtVer2/resources-avx1.s
test/tools/llvm-mca/X86/BtVer2/resources-bmi1.s
test/tools/llvm-mca/X86/BtVer2/resources-clmul.s
test/tools/llvm-mca/X86/BtVer2/resources-cmov.s
test/tools/llvm-mca/X86/BtVer2/resources-f16c.s
test/tools/llvm-mca/X86/BtVer2/resources-lzcnt.s
test/tools/llvm-mca/X86/BtVer2/resources-mmx.s
test/tools/llvm-mca/X86/BtVer2/resources-popcnt.s
test/tools/llvm-mca/X86/BtVer2/resources-sse1.s
test/tools/llvm-mca/X86/BtVer2/resources-sse2.s
test/tools/llvm-mca/X86/BtVer2/resources-sse3.s
test/tools/llvm-mca/X86/BtVer2/resources-sse41.s
test/tools/llvm-mca/X86/BtVer2/resources-sse42.s
test/tools/llvm-mca/X86/BtVer2/resources-sse4a.s
test/tools/llvm-mca/X86/BtVer2/resources-ssse3.s
test/tools/llvm-mca/X86/BtVer2/resources-x86_64.s
test/tools/llvm-mca/X86/BtVer2/resources-x87.s
test/tools/llvm-mca/X86/BtVer2/scheduler-queue-usage.s
test/tools/llvm-mca/X86/BtVer2/simple-test.s
test/tools/llvm-mca/X86/BtVer2/vec-logic-read-after-ld-1.s
test/tools/llvm-mca/X86/BtVer2/vec-logic-read-after-ld-2.s
test/tools/llvm-mca/X86/Haswell/resources-avx1.s
test/tools/llvm-mca/X86/Haswell/resources-avx2.s
test/tools/llvm-mca/X86/Haswell/resources-bmi1.s
test/tools/llvm-mca/X86/Haswell/resources-bmi2.s
test/tools/llvm-mca/X86/Haswell/resources-cmov.s
test/tools/llvm-mca/X86/Haswell/resources-f16c.s
test/tools/llvm-mca/X86/Haswell/resources-fma.s
test/tools/llvm-mca/X86/Haswell/resources-lzcnt.s
test/tools/llvm-mca/X86/Haswell/resources-mmx.s
test/tools/llvm-mca/X86/Haswell/resources-popcnt.s
test/tools/llvm-mca/X86/Haswell/resources-sse1.s
test/tools/llvm-mca/X86/Haswell/resources-sse2.s
test/tools/llvm-mca/X86/Haswell/resources-sse3.s
test/tools/llvm-mca/X86/Haswell/resources-sse41.s
test/tools/llvm-mca/X86/Haswell/resources-sse42.s
test/tools/llvm-mca/X86/Haswell/resources-ssse3.s
test/tools/llvm-mca/X86/Haswell/resources-x86_64.s
test/tools/llvm-mca/X86/Haswell/resources-x87.s
test/tools/llvm-mca/X86/SLM/resources-cmov.s
test/tools/llvm-mca/X86/SLM/resources-mmx.s
test/tools/llvm-mca/X86/SLM/resources-popcnt.s
test/tools/llvm-mca/X86/SLM/resources-sse1.s
test/tools/llvm-mca/X86/SLM/resources-sse2.s
test/tools/llvm-mca/X86/SLM/resources-sse3.s
test/tools/llvm-mca/X86/SLM/resources-sse41.s
test/tools/llvm-mca/X86/SLM/resources-sse42.s
test/tools/llvm-mca/X86/SLM/resources-ssse3.s
test/tools/llvm-mca/X86/SLM/resources-x86_64.s
test/tools/llvm-mca/X86/SLM/resources-x87.s
test/tools/llvm-mca/X86/SandyBridge/resources-aes.s
test/tools/llvm-mca/X86/SandyBridge/resources-avx1.s
test/tools/llvm-mca/X86/SandyBridge/resources-clmul.s
test/tools/llvm-mca/X86/SandyBridge/resources-cmov.s
test/tools/llvm-mca/X86/SandyBridge/resources-f16c.s
test/tools/llvm-mca/X86/SandyBridge/resources-mmx.s
test/tools/llvm-mca/X86/SandyBridge/resources-popcnt.s
test/tools/llvm-mca/X86/SandyBridge/resources-sse1.s
test/tools/llvm-mca/X86/SandyBridge/resources-sse2.s
test/tools/llvm-mca/X86/SandyBridge/resources-sse3.s
test/tools/llvm-mca/X86/SandyBridge/resources-sse41.s
test/tools/llvm-mca/X86/SandyBridge/resources-sse42.s
test/tools/llvm-mca/X86/SandyBridge/resources-ssse3.s
test/tools/llvm-mca/X86/SandyBridge/resources-x86_64.s
test/tools/llvm-mca/X86/SandyBridge/resources-x87.s
test/tools/llvm-mca/X86/SkylakeClient/resources-adx.s
test/tools/llvm-mca/X86/SkylakeClient/resources-avx1.s
test/tools/llvm-mca/X86/SkylakeClient/resources-avx2.s
test/tools/llvm-mca/X86/SkylakeClient/resources-bmi1.s
test/tools/llvm-mca/X86/SkylakeClient/resources-bmi2.s
test/tools/llvm-mca/X86/SkylakeClient/resources-cmov.s
test/tools/llvm-mca/X86/SkylakeClient/resources-f16c.s
test/tools/llvm-mca/X86/SkylakeClient/resources-fma.s
test/tools/llvm-mca/X86/SkylakeClient/resources-lzcnt.s
test/tools/llvm-mca/X86/SkylakeClient/resources-mmx.s
test/tools/llvm-mca/X86/SkylakeClient/resources-popcnt.s
test/tools/llvm-mca/X86/SkylakeClient/resources-sse1.s
test/tools/llvm-mca/X86/SkylakeClient/resources-sse2.s
test/tools/llvm-mca/X86/SkylakeClient/resources-sse3.s
test/tools/llvm-mca/X86/SkylakeClient/resources-sse41.s
test/tools/llvm-mca/X86/SkylakeClient/resources-sse42.s
test/tools/llvm-mca/X86/SkylakeClient/resources-ssse3.s
test/tools/llvm-mca/X86/SkylakeClient/resources-x86_64.s
test/tools/llvm-mca/X86/SkylakeClient/resources-x87.s
test/tools/llvm-mca/X86/SkylakeServer/resources-adx.s
test/tools/llvm-mca/X86/SkylakeServer/resources-avx1.s
test/tools/llvm-mca/X86/SkylakeServer/resources-avx2.s
test/tools/llvm-mca/X86/SkylakeServer/resources-bmi1.s
test/tools/llvm-mca/X86/SkylakeServer/resources-bmi2.s
test/tools/llvm-mca/X86/SkylakeServer/resources-cmov.s
test/tools/llvm-mca/X86/SkylakeServer/resources-f16c.s
test/tools/llvm-mca/X86/SkylakeServer/resources-fma.s
test/tools/llvm-mca/X86/SkylakeServer/resources-lzcnt.s
test/tools/llvm-mca/X86/SkylakeServer/resources-mmx.s
test/tools/llvm-mca/X86/SkylakeServer/resources-popcnt.s
test/tools/llvm-mca/X86/SkylakeServer/resources-sse1.s
test/tools/llvm-mca/X86/SkylakeServer/resources-sse2.s
test/tools/llvm-mca/X86/SkylakeServer/resources-sse3.s
test/tools/llvm-mca/X86/SkylakeServer/resources-sse41.s
test/tools/llvm-mca/X86/SkylakeServer/resources-sse42.s
test/tools/llvm-mca/X86/SkylakeServer/resources-ssse3.s
test/tools/llvm-mca/X86/SkylakeServer/resources-x86_64.s
test/tools/llvm-mca/X86/SkylakeServer/resources-x87.s
test/tools/llvm-mca/X86/Znver1/resources-adx.s
test/tools/llvm-mca/X86/Znver1/resources-avx1.s
test/tools/llvm-mca/X86/Znver1/resources-avx2.s
test/tools/llvm-mca/X86/Znver1/resources-bmi1.s
test/tools/llvm-mca/X86/Znver1/resources-bmi2.s
test/tools/llvm-mca/X86/Znver1/resources-cmov.s
test/tools/llvm-mca/X86/Znver1/resources-f16c.s
test/tools/llvm-mca/X86/Znver1/resources-fma.s
test/tools/llvm-mca/X86/Znver1/resources-lzcnt.s
test/tools/llvm-mca/X86/Znver1/resources-mmx.s
test/tools/llvm-mca/X86/Znver1/resources-popcnt.s
test/tools/llvm-mca/X86/Znver1/resources-sse1.s
test/tools/llvm-mca/X86/Znver1/resources-sse2.s
test/tools/llvm-mca/X86/Znver1/resources-sse3.s
test/tools/llvm-mca/X86/Znver1/resources-sse41.s
test/tools/llvm-mca/X86/Znver1/resources-sse42.s
test/tools/llvm-mca/X86/Znver1/resources-sse4a.s
test/tools/llvm-mca/X86/Znver1/resources-ssse3.s
test/tools/llvm-mca/X86/Znver1/resources-x86_64.s
test/tools/llvm-mca/X86/Znver1/resources-x87.s
test/tools/llvm-mca/X86/bextr-read-after-ld.s
test/tools/llvm-mca/X86/bzhi-read-after-ld.s
test/tools/llvm-mca/X86/cpus.s
test/tools/llvm-mca/X86/default-iterations.s
test/tools/llvm-mca/X86/dispatch_width.s
test/tools/llvm-mca/X86/fma3-read-after-ld-1.s
test/tools/llvm-mca/X86/fma3-read-after-ld-2.s
test/tools/llvm-mca/X86/in-order-cpu.s
test/tools/llvm-mca/X86/intel-syntax.s
test/tools/llvm-mca/X86/invalid-assembly-sequence.s
test/tools/llvm-mca/X86/invalid-cpu.s
test/tools/llvm-mca/X86/invalid-empty-file.s
test/tools/llvm-mca/X86/llvm-mca-markers-1.s
test/tools/llvm-mca/X86/llvm-mca-markers-2.s
test/tools/llvm-mca/X86/llvm-mca-markers-3.s
test/tools/llvm-mca/X86/llvm-mca-markers-4.s
test/tools/llvm-mca/X86/llvm-mca-markers-5.s
test/tools/llvm-mca/X86/llvm-mca-markers-6.s
test/tools/llvm-mca/X86/llvm-mca-markers-7.s
test/tools/llvm-mca/X86/no-sched-model.s
test/tools/llvm-mca/X86/option-all-stats-1.s
test/tools/llvm-mca/X86/option-all-stats-2.s
test/tools/llvm-mca/X86/option-all-views-1.s
test/tools/llvm-mca/X86/option-all-views-2.s
test/tools/llvm-mca/X86/variable-blend-read-after-ld-1.s
test/tools/llvm-mca/X86/variable-blend-read-after-ld-2.s
utils/update_mca_test_checks.py
|
can be simplified to
I think.