Page MenuHomePhabricator

[asan, myriad] Implement aligned local pool allocation
ClosedPublic

Authored by waltl on Jun 1 2018, 8:56 AM.

Diff Detail

Event Timeline

waltl created this revision.Jun 1 2018, 8:56 AM

Are you solving a particular problem or you're just anticipating one?

compiler-rt/lib/asan/asan_malloc_linux.cc
199

Let's do it for all platforms, for simplicity and match the malloc implementation.

waltl added a comment.Jun 1 2018, 1:46 PM

Are you solving a particular problem or you're just anticipating one?

It's a problem I encountered on RTEMS, where we use this memory for a different purpose. See https://reviews.llvm.org/D46465.

compiler-rt/lib/asan/asan_malloc_linux.cc
199

Ok.

waltl updated this revision to Diff 149546.Jun 1 2018, 2:17 PM

Do it for all platforms.

waltl marked 2 inline comments as done.Jun 1 2018, 2:18 PM
alekseyshl accepted this revision.Jun 1 2018, 2:26 PM
alekseyshl added inline comments.
compiler-rt/lib/asan/asan_malloc_linux.cc
195

While you're here, please remove this printf too.

This revision is now accepted and ready to land.Jun 1 2018, 2:26 PM
waltl updated this revision to Diff 149552.Jun 1 2018, 2:31 PM

Remove printf.

This revision was automatically updated to reflect the committed changes.