This is an archive of the discontinued LLVM Phabricator instance.

[ASTImporter] Add new tests about templated-described swing
ClosedPublic

Authored by martong on May 30 2018, 7:04 AM.

Details

Summary

Add a new test about importing a partial specialization (of a class). Also,
this patch adds new tests about the templated-described swing, some of these
fail ATM, but subsequent patches will fix them.

Diff Detail

Repository
rL LLVM

Event Timeline

martong created this revision.May 30 2018, 7:04 AM
a_sidorin accepted this revision.Jun 24 2018, 2:08 PM
a_sidorin added a subscriber: a_sidorin.

Hi Gabor,

Tests are always welcome. This patch is OK and can be committed after fixing nits without additional approval.

unittests/AST/ASTImporterTest.cpp
1097 ↗(On Diff #149113)

Broken indentation.

1098 ↗(On Diff #149113)

T0 * (missed space)

This revision is now accepted and ready to land.Jun 24 2018, 2:08 PM
martong updated this revision to Diff 152660.Jun 25 2018, 4:41 AM
martong marked 2 inline comments as done.
  • Clang format the test code snippet.

I addressed the comments, thanks for the review!

This revision was automatically updated to reflect the committed changes.