This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fixed build warning
ClosedPublic

Authored by tpr on May 27 2018, 10:43 AM.

Reviewers

arsenm
nhaehnle

Commits

Summary

Change-Id: I1b0f1871c9eb3f06ce82cd9bb81f5998f624a26e

Repository

rL LLVM

Build Status

Buildable 18637
Build 18637: arc lint + arc unit

What warning? I don’t see anything wrong here

It's an intrinsic vs. unsigned warning. LGTM.

This revision is now accepted and ready to land.May 27 2018, 2:05 PM

Can you add the explicit cast instead of introducing an if

This revision was automatically updated to reflect the committed changes.

I used a cast instead of the extra if in the dcommitted version.

Path

Size

lib/

Target/

AMDGPU/

8 lines

Show First 20 Lines • Show All 3,595 Lines • ▼ Show 20 Lines	SDValue SITargetLowering::adjustLoadValueType(unsigned Opcode,
if (LoadVT.isVector()) {		if (LoadVT.isVector()) {
EquivLoadVT = Unpacked ? UnpackedLoadVT :		EquivLoadVT = Unpacked ? UnpackedLoadVT :
getEquivalentMemType(*DAG.getContext(), LoadVT);		getEquivalentMemType(*DAG.getContext(), LoadVT);
}		}

// Change from v4f16/v2f16 to EquivLoadVT.		// Change from v4f16/v2f16 to EquivLoadVT.
SDVTList VTList = DAG.getVTList(EquivLoadVT, MVT::Other);		SDVTList VTList = DAG.getVTList(EquivLoadVT, MVT::Other);

SDValue Load		if (IsIntrinsic)
= DAG.getMemIntrinsicNode(IsIntrinsic ? ISD::INTRINSIC_W_CHAIN : Opcode, DL,		Opcode = ISD::INTRINSIC_W_CHAIN;
VTList, Ops, M->getMemoryVT(),		SDValue Load = DAG.getMemIntrinsicNode(Opcode, DL, VTList, Ops,
M->getMemOperand());		M->getMemoryVT(), M->getMemOperand());

SDValue Adjusted = adjustLoadValueTypeImpl(Load, LoadVT, DL, DAG, Unpacked);		SDValue Adjusted = adjustLoadValueTypeImpl(Load, LoadVT, DL, DAG, Unpacked);

return DAG.getMergeValues({ Adjusted, Load.getValue(1) }, DL);		return DAG.getMergeValues({ Adjusted, Load.getValue(1) }, DL);
}		}

void SITargetLowering::ReplaceNodeResults(SDNode *N,		void SITargetLowering::ReplaceNodeResults(SDNode *N,
SmallVectorImpl<SDValue> &Results,		SmallVectorImpl<SDValue> &Results,
▲ Show 20 Lines • Show All 4,133 Lines • Show Last 20 Lines