This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Analysis: Display idealized sched class port pressure.
ClosedPublic

Authored by courbet on May 24 2018, 7:43 AM.

Diff Detail

Event Timeline

courbet created this revision.May 24 2018, 7:43 AM
mgrang added inline comments.May 24 2018, 8:05 AM
tools/llvm-exegesis/lib/Analysis.cpp
175–176
468
491

Same here.

courbet updated this revision to Diff 148552.May 25 2018, 12:25 AM
courbet marked 3 inline comments as done.

use llvm::sort instead of std::sort

gchatelet requested changes to this revision.Jun 1 2018, 6:08 AM
gchatelet added inline comments.
tools/llvm-exegesis/lib/Analysis.cpp
309

Bring last word on the same line.

467

Can you describe what Dense and Sparse pressure are?

484

algorithm

488

Running an example of help understand the algorithm here.

499

This pattern appears quite often in the next few lines DensePressure[Subunits[XXX]].
Maybe a lambda would help.

const auto getPressureForSubUnit = [](...){...};

Or an object to encapsulate the logic?

509

How about using a function instead of this big body?
It would make the return path easier to understand.

This revision now requires changes to proceed.Jun 1 2018, 6:08 AM
courbet updated this revision to Diff 149457.Jun 1 2018, 6:54 AM
courbet marked 6 inline comments as done.

Address review comments.

Thanks, PTAL.

courbet updated this revision to Diff 149461.Jun 1 2018, 7:05 AM

fix typo, use return instead of break.

gchatelet requested changes to this revision.Jun 1 2018, 7:06 AM
gchatelet added inline comments.
tools/llvm-exegesis/lib/Analysis.cpp
493

budget

This revision now requires changes to proceed.Jun 1 2018, 7:06 AM
gchatelet accepted this revision.Jun 1 2018, 7:09 AM
This revision is now accepted and ready to land.Jun 1 2018, 7:09 AM
This revision was automatically updated to reflect the committed changes.