This is an archive of the discontinued LLVM Phabricator instance.

Differential D47294

[libFuzzer] [NFC] Generalize fdmask test.
ClosedPublic

Authored by george.karpenkov on May 23 2018, 3:23 PM.

Details

Reviewers
morehouse
vitalybuka
kcc
Commits
rG698b0a674d26: [libFuzzer] [NFC] Generalize fdmask test.
rL333245: [libFuzzer] [NFC] Generalize fdmask test.
rCRT333245: [libFuzzer] [NFC] Generalize fdmask test.
Summary

The ordering of stderr/stdout writes might not be guaranteed,

and is irrelevant for this test.

Diff Detail

Event Timeline

george.karpenkov created this revision.May 23 2018, 3:23 PM
george.karpenkov added a child revision: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.May 23 2018, 3:39 PM
morehouse added a comment.May 23 2018, 6:17 PM

Since the test flushes output after each write to stdout, why is ordering not guaranteed here?

george.karpenkov added a comment.May 23 2018, 6:25 PM

@morehouse we have issues with stdout/stderr arriving in unexpected order when run on devices and streaming across the network.
In this case adding -DAG seems like an easiest choice, since the test purpose is to check that close_fd_mask would close the corresponding file descriptor.

morehouse accepted this revision.May 23 2018, 7:03 PM
This revision is now accepted and ready to land.May 23 2018, 7:03 PM
Closed by commit rCRT333245: [libFuzzer] [NFC] Generalize fdmask test. (authored by george.karpenkov). · Explain WhyMay 24 2018, 5:00 PM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptMay 24 2018, 5:00 PM

Revision Contents

PathSize
test/
fuzzer/
24 lines

Diff 148303

test/fuzzer/fuzzer-fdmask.test

RUN: %cpp_compiler %S/SpamyTest.cpp -o %t-SpamyTest RUN: %cpp_compiler %S/SpamyTest.cpp -o %t-SpamyTest
RUN: %run %t-SpamyTest -runs=1 2>&1 | FileCheck %s --check-prefix=FD_MASK_0 RUN: %run %t-SpamyTest -runs=1 2>&1 | FileCheck %s --check-prefix=FD_MASK_0
RUN: %run %t-SpamyTest -runs=1 -close_fd_mask=0 2>&1 | FileCheck %s --check-prefix=FD_MASK_0 RUN: %run %t-SpamyTest -runs=1 -close_fd_mask=0 2>&1 | FileCheck %s --check-prefix=FD_MASK_0
RUN: %run %t-SpamyTest -runs=1 -close_fd_mask=1 2>&1 | FileCheck %s --check-prefix=FD_MASK_1 RUN: %run %t-SpamyTest -runs=1 -close_fd_mask=1 2>&1 | FileCheck %s --check-prefix=FD_MASK_1
RUN: %run %t-SpamyTest -runs=1 -close_fd_mask=2 2>&1 | FileCheck %s --check-prefix=FD_MASK_2 RUN: %run %t-SpamyTest -runs=1 -close_fd_mask=2 2>&1 | FileCheck %s --check-prefix=FD_MASK_2
RUN: %run %t-SpamyTest -runs=1 -close_fd_mask=3 2>&1 | FileCheck %s --check-prefix=FD_MASK_3 RUN: %run %t-SpamyTest -runs=1 -close_fd_mask=3 2>&1 | FileCheck %s --check-prefix=FD_MASK_3
FD_MASK_0: PRINTF_STDOUT FD_MASK_0-DAG: PRINTF_STDOUT
FD_MASK_0: PRINTF_STDERR FD_MASK_0-DAG: PRINTF_STDERR
FD_MASK_0: STREAM_COUT FD_MASK_0-DAG: STREAM_COUT
FD_MASK_0: STREAM_CERR FD_MASK_0-DAG: STREAM_CERR
FD_MASK_0: INITED FD_MASK_0-DAG: INITED
FD_MASK_1-NOT: PRINTF_STDOUT FD_MASK_1-NOT: PRINTF_STDOUT
FD_MASK_1: PRINTF_STDERR FD_MASK_1-DAG: PRINTF_STDERR
FD_MASK_1-NOT: STREAM_COUT FD_MASK_1-NOT: STREAM_COUT
FD_MASK_1: STREAM_CERR FD_MASK_1-DAG: STREAM_CERR
FD_MASK_1: INITED FD_MASK_1-DAG: INITED
FD_MASK_2: PRINTF_STDOUT FD_MASK_2-DAG: PRINTF_STDOUT
FD_MASK_2-DAG: STREAM_COUT
FD_MASK_2-DAG: INITED
FD_MASK_2-NOT: PRINTF_STDERR FD_MASK_2-NOT: PRINTF_STDERR
FD_MASK_2: STREAM_COUT FD_MASK_2-NOT: STREAM_CERR
FD_MASK_2-NOTE: STREAM_CERR
FD_MASK_2: INITED
FD_MASK_3-NOT: PRINTF_STDOUT FD_MASK_3-NOT: PRINTF_STDOUT
FD_MASK_3-NOT: PRINTF_STDERR FD_MASK_3-NOT: PRINTF_STDERR
FD_MASK_3-NOT: STREAM_COUT FD_MASK_3-NOT: STREAM_COUT
FD_MASK_3-NOT: STREAM_CERR FD_MASK_3-NOT: STREAM_CERR
FD_MASK_3: INITED FD_MASK_3: INITED