This is an archive of the discontinued LLVM Phabricator instance.

test/fuzzer/minimize_crash.test
9	Is there a way to do a partial match on the file names or use `%t.dir` in the regex? The main difference between lines 6 and 8 is whether we specify the artifact path or not. But your change makes lines 7 and 9 the same.

george.karpenkov added inline comments.May 24 2018, 2:56 PM

test/fuzzer/minimize_crash.test
9	Good point. `%t.dir` can not be used in the regex directly (as it is picked up by FileCheck as it is), but tricks can be used. TBH that further interferes with our magic for rewriting paths to run on a device. What I would really like to do is to say "match whatever until you can match not_minimal_crash". I.e. in Python regex had a mode for "lazy" matching which would have been suitable here. Any ideas how to do this in FileCheck? Conceptually, non-nested lazy matching does not require backtracking and can still be done with a DFA, and the need for it turns up often enough, so I'm quite confused as to why there's no reasonable way to match that.

morehouse added inline comments.May 24 2018, 3:22 PM

test/fuzzer/minimize_crash.test
9	I'm not sure I understand what you mean. But wouldn't these work? `failed to minimize beyond {{.}}/minimized-from-{{.}} (3 bytes)` `failed to minimize beyond {{.*}}.exact_minimized_path`

george.karpenkov added inline comments.May 24 2018, 3:26 PM

test/fuzzer/minimize_crash.test
9	But wouldn't these work? In my understanding, regular expression matching is eager, and the match on `.*` will consume the entire string, so `minimized-from` would have nothing to match on.

george.karpenkov added inline comments.May 24 2018, 3:32 PM

test/fuzzer/minimize_crash.test
9	@morehouse actually NVM, I was confused by a different regexp implementation. Thanks for your note, I'll change it!

George, how do you create such stack of patches? Is there any automated tool for that?

George, how do you create such stack of patches? Is there any automated tool for that?

Nope, I just manually commit on a branch, copy the hash git emits to the clipboard, pipe the diff through pbcopy, and then manually create the revision :(
I haven't even started using arc

george.karpenkov updated this revision to Diff 148501.May 24 2018, 4:45 PM

george.karpenkov marked an inline comment as done.

vitalybuka accepted this revision.May 25 2018, 1:10 PM

This revision is now accepted and ready to land.May 25 2018, 1:10 PM

morehouse accepted this revision.Jun 4 2018, 11:13 AM

Closed by commit rCRT334546: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests. (authored by george.karpenkov). · Explain WhyJun 12 2018, 2:18 PM

This revision was automatically updated to reflect the committed changes.

Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptJun 12 2018, 2:18 PM

Revision Contents

Path

Size

test/

fuzzer/

minimize_crash.test

23 lines

Diff 151029

test/fuzzer/minimize_crash.test

	RUN: %cpp_compiler %S/NullDerefTest.cpp -o %t-NullDerefTest			RUN: %cpp_compiler %S/NullDerefTest.cpp -o %t-NullDerefTest
	RUN: %cpp_compiler %S/SingleByteInputTest.cpp -o %t-SingleByteInputTest			RUN: %cpp_compiler %S/SingleByteInputTest.cpp -o %t-SingleByteInputTest
				RUN: mkdir -p %t.dir

	RUN: echo 'Hi!rv349f34t3gg' > not_minimal_crash			RUN: echo 'Hi!rv349f34t3gg' > %t.dir/not_minimal_crash
	RUN: %run %t-NullDerefTest -minimize_crash=1 not_minimal_crash -max_total_time=2 2>&1 \| FileCheck %s			RUN: %run %t-NullDerefTest -minimize_crash=1 %t.dir/not_minimal_crash -max_total_time=2 2>&1 \| FileCheck %s
	CHECK: CRASH_MIN: failed to minimize beyond ./minimized-from-{{.*}} (3 bytes), exiting			CHECK: CRASH_MIN: failed to minimize beyond {{.}}minimized-from{{.}} (3 bytes), exiting
	RUN: %run %t-NullDerefTest -minimize_crash=1 not_minimal_crash -max_total_time=2 -exact_artifact_path=exact_minimized_path 2>&1 \| FileCheck %s --check-prefix=CHECK_EXACT			RUN: %run %t-NullDerefTest -minimize_crash=1 %t.dir/not_minimal_crash -max_total_time=2 -exact_artifact_path=%t.exact_minimized_path 2>&1 \| FileCheck %s --check-prefix=CHECK_EXACT
	CHECK_EXACT: CRASH_MIN: failed to minimize beyond exact_minimized_path (3 bytes), exiting			CHECK_EXACT: CRASH_MIN: failed to minimize beyond {{.}}exact_minimized_path{{.}} (3 bytes), exiting
				morehouseUnsubmitted Not Done Reply Inline Actions Is there a way to do a partial match on the file names or use `%t.dir` in the regex? The main difference between lines 6 and 8 is whether we specify the artifact path or not. But your change makes lines 7 and 9 the same. morehouse: Is there a way to do a partial match on the file names or use `%t.dir` in the regex? The main…
				george.karpenkovAuthorUnsubmitted Not Done Reply Inline Actions Good point. `%t.dir` can not be used in the regex directly (as it is picked up by FileCheck as it is), but tricks can be used. TBH that further interferes with our magic for rewriting paths to run on a device. What I would really like to do is to say "match whatever until you can match not_minimal_crash". I.e. in Python regex had a mode for "lazy" matching which would have been suitable here. Any ideas how to do this in FileCheck? Conceptually, non-nested lazy matching does not require backtracking and can still be done with a DFA, and the need for it turns up often enough, so I'm quite confused as to why there's no reasonable way to match that. george.karpenkov: Good point. `%t.dir` can not be used in the regex directly (as it is picked up by FileCheck as…
				morehouseUnsubmitted Done Reply Inline Actions I'm not sure I understand what you mean. But wouldn't these work? `failed to minimize beyond {{.}}/minimized-from-{{.}} (3 bytes)` `failed to minimize beyond {{.}}.exact_minimized_path` morehouse:* I'm not sure I understand what you mean. But wouldn't these work? `failed to minimize beyond…
				george.karpenkovAuthorUnsubmitted Not Done Reply Inline Actions But wouldn't these work? In my understanding, regular expression matching is eager, and the match on `.` will consume the entire string, so `minimized-from` would have nothing to match on. george.karpenkov:* > But wouldn't these work? In my understanding, regular expression matching is eager, and the…
				george.karpenkovAuthorUnsubmitted Not Done Reply Inline Actions @morehouse actually NVM, I was confused by a different regexp implementation. Thanks for your note, I'll change it! george.karpenkov: @morehouse actually NVM, I was confused by a different regexp implementation. Thanks for your…
	RUN: rm not_minimal_crash minimized-from-* exact_minimized_path			RUN: rm %t.dir/not_minimal_crash %t.exact_minimized_path

	RUN: echo -n 'abcd*xyz' > not_minimal_crash			RUN: echo -n 'abcd*xyz' > %t.dir/not_minimal_crash
	RUN: %run %t-SingleByteInputTest -minimize_crash=1 not_minimal_crash -exact_artifact_path=exact_minimized_path 2>&1 \| FileCheck %s --check-prefix=MIN1			RUN: %run %t-SingleByteInputTest -minimize_crash=1 %t.dir/not_minimal_crash -exact_artifact_path=%t.exact_minimized_path 2>&1 \| FileCheck %s --check-prefix=MIN1
	MIN1: Test unit written to exact_minimized_path			MIN1: Test unit written to {{.*}}exact_minimized_path
	MIN1: Test unit written to exact_minimized_path			MIN1: Test unit written to {{.*}}exact_minimized_path
	MIN1: INFO: The input is small enough, exiting			MIN1: INFO: The input is small enough, exiting
	MIN1: CRASH_MIN: failed to minimize beyond exact_minimized_path (1 bytes), exiting			MIN1: CRASH_MIN: failed to minimize beyond {{.*}}exact_minimized_path (1 bytes), exiting

This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] [NFC] Do not use hardcoded relative paths in tests.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 151029

test/fuzzer/minimize_crash.test

[libFuzzer] [NFC] Do not use hardcoded relative paths in tests.
ClosedPublic