This is an archive of the discontinued LLVM Phabricator instance.

Differential D47293

[libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests
ClosedPublic

Authored by george.karpenkov on May 23 2018, 3:19 PM.

Details

Reviewers
vitalybuka
kcc
morehouse
Commits
rGb4ccb3ab0888: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests
rL333244: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests
rCRT333244: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests

Diff Detail

Event Timeline

george.karpenkov created this revision.May 23 2018, 3:19 PM
Herald added a subscriber: mgorny. · View Herald TranscriptMay 23 2018, 3:19 PM
george.karpenkov added a child revision: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.May 23 2018, 3:39 PM
morehouse accepted this revision.May 23 2018, 6:21 PM

LGTM.

This revision is now accepted and ready to land.May 23 2018, 6:21 PM
Closed by commit rCRT333244: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests (authored by george.karpenkov). · Explain WhyMay 24 2018, 5:00 PM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptMay 24 2018, 5:00 PM

Revision Contents

PathSize
test/
fuzzer/
1 line

Diff 148513

test/fuzzer/CMakeLists.txt

set(LIBFUZZER_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS}) set(LIBFUZZER_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
list(REMOVE_ITEM LIBFUZZER_TEST_DEPS SanitizerLintCheck)
if (NOT COMPILER_RT_STANDALONE_BUILD) if (NOT COMPILER_RT_STANDALONE_BUILD)
list(APPEND LIBFUZZER_TEST_DEPS fuzzer asan ubsan) list(APPEND LIBFUZZER_TEST_DEPS fuzzer asan ubsan)
endif() endif()
if(COMPILER_RT_INCLUDE_TESTS) if(COMPILER_RT_INCLUDE_TESTS)
list(APPEND LIBFUZZER_TEST_DEPS FuzzerUnitTests) list(APPEND LIBFUZZER_TEST_DEPS FuzzerUnitTests)
endif() endif()
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines