[libFuzzer] [NFC] Do not use hardcoded relative paths in tests.

[george.karpenkov]

Summary

For paths without "%t" inside uniqueness is not guaranteed, and

potential collisions might be present.

[morehouse]

test/fuzzer/minimize_crash.test

9

Is there a way to do a partial match on the file names or use %t.dir in the regex?

The main difference between lines 6 and 8 is whether we specify the artifact path or not. But your change makes lines 7 and 9 the same.

[george.karpenkov]

test/fuzzer/minimize_crash.test

9

Good point. %t.dir can not be used in the regex directly (as it is picked up by FileCheck as it is), but tricks can be used. TBH that further interferes with our magic for rewriting paths to run on a device.

What I would really like to do is to say "match whatever until you can match not_minimal_crash". I.e. in Python regex had a mode for "lazy" matching which would have been suitable here.
Any ideas how to do this in FileCheck? Conceptually, non-nested lazy matching does not require backtracking and can still be done with a DFA, and the need for it turns up often enough, so I'm quite confused as to why there's no reasonable way to match that.

[morehouse]

test/fuzzer/minimize_crash.test

9

I'm not sure I understand what you mean. But wouldn't these work?

failed to minimize beyond {{.*}}/minimized-from-{{.*}} (3 bytes)
failed to minimize beyond {{.*}}.exact_minimized_path

[george.karpenkov]

test/fuzzer/minimize_crash.test

9

But wouldn't these work?

In my understanding, regular expression matching is eager, and the match on .* will consume the entire string, so minimized-from would have nothing to match on.

[george.karpenkov]

test/fuzzer/minimize_crash.test

9

@morehouse actually NVM, I was confused by a different regexp implementation. Thanks for your note, I'll change it!

[vitalybuka]

George, how do you create such stack of patches? Is there any automated tool for that?

[george.karpenkov]

George, how do you create such stack of patches? Is there any automated tool for that?

Nope, I just manually commit on a branch, copy the hash git emits to the clipboard, pipe the diff through pbcopy, and then manually create the revision :(
I haven't even started using arc

test/fuzzer/minimize_crash.test

 RUN: %cpp_compiler %S/NullDerefTest.cpp -o %t-NullDerefTest
 RUN: %cpp_compiler %S/SingleByteInputTest.cpp -o %t-SingleByteInputTest
+RUN: mkdir -p %t.dir
 
-RUN: echo 'Hi!rv349f34t3gg' > not_minimal_crash
-RUN: %run %t-NullDerefTest -minimize_crash=1 not_minimal_crash -max_total_time=2 2>&1 | FileCheck %s
-CHECK: CRASH_MIN: failed to minimize beyond ./minimized-from-{{.*}} (3 bytes), exiting
-RUN: %run %t-NullDerefTest -minimize_crash=1 not_minimal_crash -max_total_time=2 -exact_artifact_path=exact_minimized_path 2>&1 | FileCheck %s --check-prefix=CHECK_EXACT
-CHECK_EXACT: CRASH_MIN: failed to minimize beyond exact_minimized_path (3 bytes), exiting
-RUN: rm not_minimal_crash minimized-from-* exact_minimized_path
+RUN: echo 'Hi!rv349f34t3gg' > %t.dir/not_minimal_crash
+RUN: %run %t-NullDerefTest -minimize_crash=1 %t.dir/not_minimal_crash -max_total_time=2 2>&1 | FileCheck %s
+CHECK: CRASH_MIN: failed to minimize beyond {{.*}} (3 bytes), exiting
+RUN: %run %t-NullDerefTest -minimize_crash=1 %t.dir/not_minimal_crash -max_total_time=2 -exact_artifact_path=%t.exact_minimized_path 2>&1 | FileCheck %s --check-prefix=CHECK_EXACT
+CHECK_EXACT: CRASH_MIN: failed to minimize beyond {{.*}} (3 bytes), exiting
+RUN: rm %t.dir/not_minimal_crash %t.exact_minimized_path
 
-RUN: echo -n 'abcd*xyz' > not_minimal_crash
-RUN: %run %t-SingleByteInputTest -minimize_crash=1 not_minimal_crash -exact_artifact_path=exact_minimized_path 2>&1 | FileCheck %s --check-prefix=MIN1
-MIN1: Test unit written to exact_minimized_path
-MIN1: Test unit written to exact_minimized_path
+RUN: echo -n 'abcd*xyz' > %t.dir/not_minimal_crash
+RUN: %run %t-SingleByteInputTest -minimize_crash=1 %t.dir/not_minimal_crash -exact_artifact_path=%t.exact_minimized_path 2>&1 | FileCheck %s --check-prefix=MIN1
+MIN1: Test unit written to {{.*}}
+MIN1: Test unit written to {{.*}}
 MIN1: INFO: The input is small enough, exiting
-MIN1: CRASH_MIN: failed to minimize beyond exact_minimized_path (1 bytes), exiting
+MIN1: CRASH_MIN: failed to minimize beyond {{.*}} (1 bytes), exiting