Page MenuHomePhabricator

2/3: Use DWARFBaseDIE as compile-time protection
ClosedPublic

Authored by jankratochvil on May 23 2018, 12:03 PM.

Details

Summary

As suggested by Pavel Labath in D46810 DWARFUnit::GetUnitDIEOnly() returning a pointer to m_first_die should not permit using methods like GetFirstChild().

Diff Detail

Repository
rL LLVM

Event Timeline

jankratochvil created this revision.May 23 2018, 12:03 PM

Waiting for answers on renaming from patch 1/3 before commenting.

Rename to DWARFBaseDIE and this is good to go.

jankratochvil retitled this revision from 2/3: Use DWARFBasicDIE as compile-time protection to 2/3: Use DWARFBaseDIE as compile-time protection.
This revision was not accepted when it landed; it landed in state Needs Review.May 24 2018, 1:55 PM
This revision was automatically updated to reflect the committed changes.