Page MenuHomePhabricator

[StaticAnalyzer] Added a getLValue method to ProgramState for bases
ClosedPublic

Authored by Szelethus on May 15 2018, 9:53 AM.

Diff Detail

Repository
rC Clang

Event Timeline

Szelethus created this revision.May 15 2018, 9:53 AM
NoQ accepted this revision.May 15 2018, 5:35 PM

Looks good, thanks! Yeah, seems that these were accidentally omitted.

You may want to add the const CXXRecordDecl * variant as well.

This revision is now accepted and ready to land.May 15 2018, 5:35 PM
NoQ added inline comments.May 15 2018, 5:36 PM
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
736

I think you wanted to say const auto * here. It's not really important that the local variable is const, but that the pointer points to const.

Szelethus updated this revision to Diff 147033.May 16 2018, 3:17 AM
Szelethus edited the summary of this revision. (Show Details)

Added a CXXRecordDecl version.

Szelethus marked an inline comment as done.May 16 2018, 3:18 AM
Szelethus updated this revision to Diff 147045.May 16 2018, 4:23 AM

Fixed a typo.

Thanks for the review!

If you like the new overload, can you please commit this for me?

This revision was automatically updated to reflect the committed changes.