Page MenuHomePhabricator

Remove append parameter to FindGlobalVariables
ClosedPublic

Authored by tromey on May 15 2018, 8:56 AM.

Details

Summary

As discussed in https://bugs.llvm.org/show_bug.cgi?id=37317,
FindGlobalVariables does not properly handle the case where
append=false. As this doesn't seem to be used in the tree, this patch
removes the parameter entirely.

Diff Detail

Repository
rL LLVM

Event Timeline

tromey created this revision.May 15 2018, 8:56 AM

I couldn't find any additional uses of FindGlobalVariables in swift-lldb either.

clayborg accepted this revision.May 15 2018, 9:22 PM
This revision is now accepted and ready to land.May 15 2018, 9:22 PM

I don't have commit access, so could someone please land this for me?

Thanks for the patch. I've clang-formatted it and committed in r333639.

labath closed this revision.May 31 2018, 2:50 AM
This revision was automatically updated to reflect the committed changes.