- User Since
- Nov 1 2017, 12:51 PM (207 w, 4 d)
Sep 21 2018
Could someone please land this for me? Thank you.
Sep 20 2018
May 31 2018
I don't have write access so someone will have to land this for me. Thanks.
May 29 2018
May 16 2018
I don't have commit access, so could someone please land this for me?
May 15 2018
Mar 29 2018
I only found this because I tried to use it in my rust plugin. So, I would rather implement it, because if I removed it, I would have to find a new way to do this.
Mar 26 2018
Mar 23 2018
Add unit test
Mar 21 2018
I've also noticed that int->float conversion in Scalar seems incorrect. At least, Scalar.h claims that Scalar follows C promotion rules, but int->float conversion is done using bitwise reinterpretation rather than preserving the value. I have a patch for this, but I don't know whether or not it's correct to change.
Mar 20 2018
Feb 6 2018
Could someone land this for me? I don't have access to do that. Thanks!
Jan 31 2018
Rebased & added hashing test.
Jan 30 2018
Jan 26 2018
Updates according to review. This then pointed out a buglet in
dwarfdump, now fixed.
Updated the commit message.
Jan 25 2018
Jan 24 2018
This is a new version of the discriminated union patch.
Jan 19 2018
FWIW, I had forgotten about this, but when I was first writing this patch I did find a dwarf-discuss thread about the discriminant placement issue: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2006-August/001710.html
Jan 18 2018
Having the DIE shape conform to DWARF seems easy in this patch -- just a reordering in DwarfUnit::constructDiscriminatorDIE. However I don't see how to nicely support univariant Rust enums; the variant part is triggered by having a discriminator, but these objects don't have enumerators.
I filed a GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83935, and contacted a friend at AdaCore to see what they think.
Another thing to consider is that this is really just the first patch in a larger project. There are other things in Rust that will require new debuginfo. Some of these can be mapped to existing DWARF (e.g., traits can probably use DW_TAG_interface pretty comfortably); but some cannot (e.g., the distinction between tuples and structs).
Well, you'll want an actual enumeration_type for the type of the struct's field, and if enums don't otherwise occur naturally in Rust, that seems like a pretty good indication all by itself.
Jan 17 2018
That said, I'm happy to support a proposal to move the discriminant's member description out from under TAG_variant_part. Especially given GCC's practice, which probably is the same for Pascal as it is for Ada.
Jan 16 2018
Jan 15 2018
Adding you for review because I think you reviewed earlier changes to this file.
Nov 8 2017
Thanks for the reviews. I don't have commit access, so could someone please check this in for me?
Nov 2 2017
Add a test based on rustc output
Address review comments