This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Don't force the IEEE bit for Mesa compute shaders.
Needs RevisionPublic

Authored by bnieuwenhuizen on May 13 2018, 12:50 PM.

Details

Reviewers
nhaehnle
arsenm
Summary

Neither GL nor Vulkan have any requirements on signaling/quiet
NaNs.

Diff Detail

Event Timeline

arsenm requested changes to this revision.May 14 2018, 12:13 AM

This needs a test (I'm pretty sure it already exists and should break with this change).

Nobody has any requirement for signaling nans, but it's unclear you actually want to do this. I think things are moving in the direction of having this on at all times.

This revision now requires changes to proceed.May 14 2018, 12:13 AM

No tests fail with this, seems like the tests for this use CL kernels.

Reason I took a stab at disabling this is that it seems to disables some of the output modifiers:

https://github.com/llvm-mirror/llvm/blob/master/lib/Target/AMDGPU/SIFoldOperands.cpp#L994

arsenm resigned from this revision.Apr 5 2020, 6:51 AM

This patch should be obsolete. The default is still to enable the IEEE bit for all compute shaders, but you can override this with the amdgpu-ieee attribute