This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix compilation failure when IR contains comdat
ClosedPublic

Authored by yaxunl on May 11 2018, 1:17 PM.

Details

Summary

Remove a useless SwitchSection which also causes compilation failure
when IR contains comdat.

The SwitchSection is useless because the current section is already
correct text section for the function therefore no need to switch.

It causes compilation failure for comdat because functions with comdat
has specific text section, not the default .text section.

Since HIP uses comdat, this bug caused failures for HIP.

Diff Detail

Event Timeline

yaxunl created this revision.May 11 2018, 1:17 PM
This revision is now accepted and ready to land.May 11 2018, 1:19 PM
This revision was automatically updated to reflect the committed changes.