This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Move #include related style to libToolingCore
ClosedPublic

Authored by ioeric on May 11 2018, 8:53 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ioeric created this revision.May 11 2018, 8:53 AM
ilya-biryukov added inline comments.May 11 2018, 9:33 AM
lib/Format/Format.cpp
461 ↗(On Diff #146336)

Should we move this to tooling::Core too?
If we need to specialize MappingTraits, we should probably do it close to the class definitions. To avoid accidental ODR violations...

ioeric updated this revision to Diff 146390.May 11 2018, 12:38 PM
ioeric marked an inline comment as done.
  • also moved yaml traits.

LG. Just a quick comment about possibly unrelated change.

lib/Format/Format.cpp
2277 ↗(On Diff #146390)

This change seems unrelated. Is this patch a proper place for it?

ioeric updated this revision to Diff 146598.May 14 2018, 7:02 AM
ioeric marked an inline comment as done.
  • Remove an unintended change.
lib/Format/Format.cpp
2277 ↗(On Diff #146390)

Indeed this was unrelated. I forgot to revert this when splitting from a previous patch.

This revision is now accepted and ready to land.May 14 2018, 8:27 AM
This revision was automatically updated to reflect the committed changes.