This is an archive of the discontinued LLVM Phabricator instance.

[diagtool] Install diagtool
ClosedPublic

Authored by JDevlieghere on May 10 2018, 8:14 AM.

Download Raw Diff

Details

Reviewers

arphaman
dexonsmith
jkorous
rsmith

Commits

rGb48447a1d603: [diagtool] Add diagtool to install target.
rC332448: [diagtool] Add diagtool to install target.
rL332448: [diagtool] Add diagtool to install target.

Summary

Although not very well known, diagtool is an incredibly convenient utility for dealing with diagnostics. I believe it's worth adding this to the install target.

Diff Detail

Repository: rC Clang

Event Timeline

JDevlieghere created this revision.May 10 2018, 8:14 AM

Herald added a subscriber: mgorny. · View Herald TranscriptMay 10 2018, 8:14 AM

This SGTM, but I wouldn't mind hearing from others. I wonder if this is worth a quick RFC on cfe-dev?

In D46694#1094617, @dexonsmith wrote:

This SGTM, but I wouldn't mind hearing from others. I wonder if this is worth a quick RFC on cfe-dev?

Sounds good, I've created a thread here: http://lists.llvm.org/pipermail/cfe-dev/2018-May/057946.html

Sgtm. I think it would be worthwhile to release-note this.

This revision was not accepted when it landed; it landed in state Needs Review.May 16 2018, 3:27 AM

Closed by commit rL332448: [diagtool] Add diagtool to install target. (authored by JDevlieghere). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

clang/

tools/

diagtool/

CMakeLists.txt

12 lines

Diff 146129

clang/tools/diagtool/CMakeLists.txt

Show All 11 Lines	add_clang_executable(diagtool
TreeView.cpp		TreeView.cpp
)		)

target_link_libraries(diagtool		target_link_libraries(diagtool
PRIVATE		PRIVATE
clangBasic		clangBasic
clangFrontend		clangFrontend
)		)

		if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
		install(TARGETS diagtool
		COMPONENT diagtool
		RUNTIME DESTINATION bin)

		if (NOT CMAKE_CONFIGURATION_TYPES)
		add_llvm_install_targets(install-diagtool
		DEPENDS diagtool
		COMPONENT diagtool)
		endif()
		endif()