Separate unit tests for the new function will be added in followup patch which will further refactor Headers.h
Details
Diff Detail
- Repository
- rCTE Clang Tools Extra
- Build Status
Buildable 18052 Build 18052: arc lint + arc unit
Event Timeline
clangd/ClangdUnit.h | ||
---|---|---|
53–55 | this might be a good place to explain *why* we collect these - processes like code completion will need #include information later, and their compile action skips the preamble range | |
clangd/Headers.h | ||
47 | as Ilya suggested, I like the idea of passing a callback(Inclusion) here rather than a vector reference. It's much more obvious at the callsite what's going to happen (and doesn't force the use of the vector). |
this might be a good place to explain *why* we collect these - processes like code completion will need #include information later, and their compile action skips the preamble range