This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Don't add -dwarf-column-info when using -gcodeview on non-msvc targets
ClosedPublic

Authored by mstorsjo on Apr 30 2018, 1:49 PM.

Details

Summary

-dwarf-column-info is omitted if -gcodeview is specified for msvc targets at the moment, but since -gcodeview is an option that can be specified for any target, there's little reason to restrict this handling to msvc targets.

This allows getting proper codeview debug info by passing -gcodeview for e.g. MinGW targets as well.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 30 2018, 1:49 PM
smeenai accepted this revision.Apr 30 2018, 6:38 PM

Makes sense to me. You may wanna wait for @zturner, but I can't really imagine any benefit to restricting this to MSVC.

This revision is now accepted and ready to land.Apr 30 2018, 6:38 PM
This revision was automatically updated to reflect the committed changes.