This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Asm: Support for non-temporal, contiguous LDNT1/STNT1 load/store instructions.
ClosedPublic

Authored by sdesmalen on Apr 30 2018, 9:27 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sdesmalen created this revision.Apr 30 2018, 9:27 AM
samparker accepted this revision.May 2 2018, 1:38 AM

LGTM, cheers.

test/MC/AArch64/SVE/ldnt1b-diagnostics.s
13 ↗(On Diff #144571)

Just curious, but what happens if MUL VL is excluded? Is it just syntactic sugar?

This revision is now accepted and ready to land.May 2 2018, 1:38 AM
sdesmalen added inline comments.May 2 2018, 3:18 AM
test/MC/AArch64/SVE/ldnt1b-diagnostics.s
13 ↗(On Diff #144571)

If the 'mul vl' is omitted you get an invalid operand on the ']' token. Basically, the ', mul vl' is parsed and re-inserted as a literal string token (in parseOptionalMulVl), which is then matched to the literal string in the instruction definition.

This revision was automatically updated to reflect the committed changes.