This is an archive of the discontinued LLVM Phabricator instance.

[LLD][ELF][AArch64] Increase test coverage of AArch64ErrataFix [NFC]
ClosedPublic

Authored by peter.smith on Apr 30 2018, 6:11 AM.

Details

Summary

In the recognise test convert some ST1 multiple structure to ST1 single structure to test the isST1SingleOpcode() function. This was found to be uncovered in a recent code coverage report.

I had thought I had covered the ST1 single structure form by putting just one register in the argument list (st1 {v0.16b}, [x1], x2), however it turns out that I needed to use a different syntax (st1 {v0.b}[1], [x1], x2).

Diff Detail

Repository
rL LLVM

Event Timeline

peter.smith created this revision.Apr 30 2018, 6:11 AM
grimar added a subscriber: grimar.May 3 2018, 1:32 AM
ruiu accepted this revision.May 5 2018, 9:20 AM

LGTM

This revision is now accepted and ready to land.May 5 2018, 9:20 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.