This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Implement select() for G_IMPLICIT_DEF
ClosedPublic

Authored by tstellar on Apr 26 2018, 4:14 PM.

Diff Detail

Event Timeline

tstellar created this revision.Apr 26 2018, 4:14 PM

Is the default implementation really unable to do this? That seems a bit silly...

tstellar updated this revision to Diff 151299.Jun 13 2018, 8:31 PM

We also need to constrain the register class when we select G_IMPLICIT_DEF.

Is the default implementation really unable to do this? That seems a bit silly...

The default implementation doesn't know how to constrain register classes for generic instructions, which is why targets have to select these generic opcodes. The original version of my patch was not doing that, but it is now.

arsenm accepted this revision.Jun 14 2018, 12:03 AM

LGTM

This revision is now accepted and ready to land.Jun 14 2018, 12:03 AM
This revision was automatically updated to reflect the committed changes.