This is an archive of the discontinued LLVM Phabricator instance.

Differential D46149

AMDGPU/GlobalISel: Don't try to lower hull shaders
ClosedPublic

Authored by tstellar on Apr 26 2018, 4:06 PM.

Details

Reviewers
arsenm
nhaehnle
Commits
rG37444285f1ea: AMDGPU/GlobalISel: Don't try to lower hull shaders
rL331691: AMDGPU/GlobalISel: Don't try to lower hull shaders
Summary

The AMDGPU_HS calling convention is not supported yet.

Diff Detail

Event Timeline

tstellar created this revision.Apr 26 2018, 4:06 PM
Herald added subscribers: t-tye, tpr, dstuttard and 5 others. · View Herald TranscriptApr 26 2018, 4:06 PM
Harbormaster completed remote builds in B17474: Diff 144232.Apr 26 2018, 4:06 PM
nhaehnle accepted this revision.Apr 30 2018, 1:07 AM

One typo, LGTM apart from that.

lib/Target/AMDGPU/AMDGPUCallLowering.cpp
91

AMDGP*U*_HS

This revision is now accepted and ready to land.Apr 30 2018, 1:07 AM
Closed by commit rL331691: AMDGPU/GlobalISel: Don't try to lower hull shaders (authored by tstellar). · Explain WhyMay 7 2018, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
AMDGPU/
5 lines

Diff 144232

lib/Target/AMDGPU/AMDGPUCallLowering.cpp

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Lines MachineMemOperand *MMO =
TypeSize, Align); TypeSize, Align);
MIRBuilder.buildLoad(DstReg, PtrReg, *MMO); MIRBuilder.buildLoad(DstReg, PtrReg, *MMO);
} }
bool AMDGPUCallLowering::lowerFormalArguments(MachineIRBuilder &MIRBuilder, bool AMDGPUCallLowering::lowerFormalArguments(MachineIRBuilder &MIRBuilder,
const Function &F, const Function &F,
ArrayRef<unsigned> VRegs) const { ArrayRef<unsigned> VRegs) const {
// AMDGPU_GS is not supported yet. // AMDGPU_GS and AMDGP_HS are not supported yet.
nhaehnleUnsubmitted
Not Done
ReplyInline Actions

AMDGP*U*_HS

nhaehnle: AMDGP*U*_HS
if (F.getCallingConv() == CallingConv::AMDGPU_GS) if (F.getCallingConv() == CallingConv::AMDGPU_GS ||
F.getCallingConv() == CallingConv::AMDGPU_HS)
return false; return false;
MachineFunction &MF = MIRBuilder.getMF(); MachineFunction &MF = MIRBuilder.getMF();
const SISubtarget *Subtarget = static_cast<const SISubtarget *>(&MF.getSubtarget()); const SISubtarget *Subtarget = static_cast<const SISubtarget *>(&MF.getSubtarget());
MachineRegisterInfo &MRI = MF.getRegInfo(); MachineRegisterInfo &MRI = MF.getRegInfo();
SIMachineFunctionInfo *Info = MF.getInfo<SIMachineFunctionInfo>(); SIMachineFunctionInfo *Info = MF.getInfo<SIMachineFunctionInfo>();
const SIRegisterInfo *TRI = MF.getSubtarget<SISubtarget>().getRegisterInfo(); const SIRegisterInfo *TRI = MF.getSubtarget<SISubtarget>().getRegisterInfo();
const DataLayout &DL = F.getParent()->getDataLayout(); const DataLayout &DL = F.getParent()->getDataLayout();
▲ Show 20 Lines • Show All 126 Lines • Show Last 20 Lines