This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][AsmParser] NFC: Cleanup of addOperands functions
ClosedPublic

Authored by sdesmalen on Apr 26 2018, 7:43 AM.

Details

Summary

Most of the add<operandname>Operands() functions are the same
and can be replaced by using a single 'RenderMethod' in
the AArch64InstrFormats.td file. Since many of the scaled
immediates (with different scaling/bits) are the same, most of
these can reuse the same AsmOperandClass.

Diff Detail

Event Timeline

sdesmalen created this revision.Apr 26 2018, 7:43 AM
samparker accepted this revision.Apr 27 2018, 12:58 AM

Great stuff, LGTM.

This revision is now accepted and ready to land.Apr 27 2018, 12:58 AM
This revision was automatically updated to reflect the committed changes.