This is an archive of the discontinued LLVM Phabricator instance.

[CodeComplete] Expose helpers to get RawComment of completion result.
ClosedPublic

Authored by ilya-biryukov on Apr 24 2018, 4:52 AM.

Diff Detail

Event Timeline

ilya-biryukov created this revision.Apr 24 2018, 4:52 AM

This seems to do what we want for clangd, but we should also get the code owner or someone who knows the code better to take a look.

Remove accidentally added changes that should be part of D46000

ilya-biryukov added a subscriber: arphaman.

This seems to do what we want for clangd, but we should also get the code owner or someone who knows the code better to take a look.

Added @arphaman. Alex reviewed some of our code completion patches before.
This should give us enough coverage to make sure we don't go in the wrong direction.

If there's someone else who should be in the reviewers list, please don't hesitate to add them.

@arphaman, friendly ping. In case you're the wrong person to review it, I'll try to find someone else.

sammccall accepted this revision.May 14 2018, 1:32 AM

This is pretty small and seems unlikely to be controversial. I think it's OK to commit at this point, it's been a few weeks.

include/clang/Sema/CodeCompleteConsumer.h
1092

as in the other patch, I think ArgIndex is a better name for this parameter, when considering this function in isolation

This revision is now accepted and ready to land.May 14 2018, 1:32 AM
ilya-biryukov marked an inline comment as done.
  • Rebase onto head and remove \brief from the comments, it's gone upstream now
  • Rename CurrentArg to ArgIndex
This revision was automatically updated to reflect the committed changes.