This allows passing additional CMake flags to builtins and runtimes
build through Fuchsia cache files.
We now also set build type and enable assertions for builtins and
runtimes build which wasn't the case before, but should've been.
Paths
| Differential D45997
[CMake] Pass additional CMake flags in Fuchsia cache files ClosedPublic Authored by phosek on Apr 23 2018, 5:17 PM.
Details Summary This allows passing additional CMake flags to builtins and runtimes We now also set build type and enable assertions for builtins and
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Apr 24 2018, 11:03 AM phosek marked an inline comment as done. Closed by commit rL331717: [CMake] Pass additional CMake flags in Fuchsia cache files (authored by phosek). · Explain WhyMay 7 2018, 7:50 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 144824 clang/cmake/caches/Fuchsia-stage2.cmake
clang/cmake/caches/Fuchsia.cmake
|
This should probably go away for now if we want to have D46079.
Then I can go through the remaining warnings if that's important to have it and fix them.