This is an archive of the discontinued LLVM Phabricator instance.

[X86] directstore and movdir64b intrinsics
ClosedPublic

Authored by GBuella on Apr 23 2018, 1:13 PM.

Diff Detail

Event Timeline

GBuella created this revision.Apr 23 2018, 1:13 PM
craig.topper added inline comments.Apr 23 2018, 2:05 PM
docs/ClangCommandLineReference.rst
2465

Please alphabetize this correctly.

include/clang/Basic/BuiltinsX86.def
1896

The u64 versions needs to go in BuiltinsX86_64.def. That will provide an extra safety check to prevent anyone from using the builtin without the intrin.h header on 32-bit hosts.

include/clang/Driver/Options.td
2634

Alphabetize

lib/Basic/Targets/X86.cpp
1304

Alphabetize

1379

Alphabetize

lib/Headers/movdirintrin.h
31

We aren't supposed to be checking the preprocessor defines in headers. We need to be able to put a target attribute on each function and control feature enabling at a function level.

36

Use 'unsigned int' instead of UINT32_TYPE

36

Lower case variable names

46

Use unsigned long long

GBuella updated this revision to Diff 143642.Apr 23 2018, 2:23 PM
GBuella updated this revision to Diff 143644.Apr 23 2018, 2:27 PM
GBuella updated this revision to Diff 143647.Apr 23 2018, 2:31 PM
GBuella marked 8 inline comments as done.
GBuella marked an inline comment as done.
craig.topper added inline comments.Apr 23 2018, 2:52 PM
lib/Headers/movdirintrin.h
40

Sorry, the X86_64 preprocessor check should have stayed. That can't be changed by a target attribute.

GBuella updated this revision to Diff 143718.Apr 24 2018, 5:45 AM
GBuella marked an inline comment as done.
This revision is now accepted and ready to land.Apr 24 2018, 9:47 AM
This revision was automatically updated to reflect the committed changes.