[lit] Generate a single lit cfg file for tests that require dotest.py

[stella.stamenova]

Summary

The current way that the lit configuration is generated for the LLDB tests that run using dotest causes cmake to fail when using a generator which supports multiple configurations (such as Visual Studio). The failure is because file GENERATE will create a file *per possible configuration* resulting in the same lit configuration file being overwritten multiple times.

To fix the issue, we need to create a single lit file that is agnostic of the configurations and can be used for any configuration.

[JDevlieghere]

One inline question/suggestion but otherwise this LGTM. Thanks Stella!

test/CMakeLists.txt

125

Is there any disadvantage to moving this and the next set or arguments to the LLDB_EXECUTABLE_PATH_ARGS_STR?

168

s/coopy/copy/

[stella.stamenova]

Fix a couple of comments to be more accurate and fix a typo

[stella.stamenova]

I don't have commit permissions, @JDevlieghere or @asmith, would you be kind enough to check it in?

test/CMakeLists.txt

125

They need to be in the common arguments since they need to be appended in both cases (for lit and for dotest).

If you are asking whether if we put them in LLDB_EXECUTABLE_PATH_ARGS_STR and did the build_mode replacement it would change them - it won't since they won't contain CMAKE_CFG_INTDIR.

If you are asking whether we can append them to LLDB_EXECUTABLE_PATH_ARGS (without STR), that's not sufficient either since we need them to end up in the lit file as well.

test/CMakeLists.txt

if (NOT LLDB_TEST_HIDE_CONSOLE_WINDOWS)
     set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS} --show-inferior-console)
   endif()
 endif()
 
 if(LLDB_CODESIGN_IDENTITY)
   list(APPEND LLDB_TEST_COMMON_ARGS --codesign-identity "${LLDB_CODESIGN_IDENTITY}")
 endif()
 
 # The framework path is passed to the test arguments as $<TARGET_FILE_DIR:liblldb>. This won't work in the
-# LLDB_DOTEST_ARGS when using a generator that supports multiple configurations such as Visual Studio,
+# LLDB_DOTEST_ARGS_STR when using a generator that supports multiple configurations such as Visual Studio,
 # but since the framework is currently confined to Darwin/Apple, we can leave it as is.
 if(LLDB_BUILD_FRAMEWORK)
   list(APPEND LLDB_TEST_COMMON_ARGS --framework $<TARGET_FILE_DIR:liblldb>)
 endif()
 
 if (NOT ${CMAKE_SYSTEM_NAME} MATCHES "Windows|Darwin")
   list(APPEND LLDB_TEST_COMMON_ARGS
     --env ARCHIVER=${CMAKE_AR} --env OBJCOPY=${CMAKE_OBJCOPY})
 endif()
 
 # In some cases, DEBUGSERVER_PATH is expressed as $<TARGET_FILE:debugserver>. This won't work in the
-# LLDB_DOTEST_ARGS when using a generator that supports multiple configurations such as Visual Studio,
+# LLDB_DOTEST_ARGS_STR when using a generator that supports multiple configurations such as Visual Studio,
 # but since debugserver is currently confined to Darwin/Apple, we can leave it as is.
 if(CMAKE_HOST_APPLE)
   list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH})
 endif()
 
 if(SKIP_DEBUGSERVER)
   list(APPEND LLDB_TEST_COMMON_ARGS --out-of-tree-debugserver)
 endif()

 
 # Generate a wrapper for dotest.py in the bin directory.
 # We need configure_file to substitute variables.
 configure_file(
   lldb-dotest.in
   ${CMAKE_CURRENT_BINARY_DIR}/lldb-dotest.configured
   )
 # We need this to expand the generator expressions. TARGET_FILE_DIR is OK here because we want to
-# generate a coopy of lldb-dotest per configuration.
+# generate a copy of lldb-dotest per configuration.
 file(GENERATE
   OUTPUT
   $<TARGET_FILE_DIR:lldb>/lldb-dotest
   INPUT
   ${CMAKE_CURRENT_BINARY_DIR}/lldb-dotest.configured
   )
 # Make this a custom target.
 add_custom_target(lldb-dotest)