This is an archive of the discontinued LLVM Phabricator instance.

Differential D45843

AMDGPU/GlobalISel: Fall-back to SelectionDAG for non-void functions
ClosedPublic

Authored by tstellar on Apr 19 2018, 3:33 PM.

Details

Reviewers
arsenm
nhaehnle
Commits
rG257882ff7276: AMDGPU/GlobalISel: Fall-back to SelectionDAG for non-void functions
rL330774: AMDGPU/GlobalISel: Fall-back to SelectionDAG for non-void functions

Diff Detail

Event Timeline

tstellar created this revision.Apr 19 2018, 3:33 PM
Harbormaster completed remote builds in B17244: Diff 143176.Apr 19 2018, 3:33 PM
Herald added subscribers: t-tye, tpr, dstuttard and 6 others. · View Herald TranscriptApr 19 2018, 3:33 PM
nhaehnle accepted this revision.Apr 19 2018, 11:51 PM

LGTM

This revision is now accepted and ready to land.Apr 19 2018, 11:51 PM
Closed by commit rL330774: AMDGPU/GlobalISel: Fall-back to SelectionDAG for non-void functions (authored by tstellar). · Explain WhyApr 24 2018, 2:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
AMDGPU/
4 lines
test/
CodeGen/
AMDGPU/
GlobalISel/
10 lines

Diff 143176

lib/Target/AMDGPU/AMDGPUCallLowering.cpp

Show All 26 Lines
using namespace llvm; using namespace llvm;
AMDGPUCallLowering::AMDGPUCallLowering(const AMDGPUTargetLowering &TLI) AMDGPUCallLowering::AMDGPUCallLowering(const AMDGPUTargetLowering &TLI)
: CallLowering(&TLI), AMDGPUASI(TLI.getAMDGPUAS()) { : CallLowering(&TLI), AMDGPUASI(TLI.getAMDGPUAS()) {
} }
bool AMDGPUCallLowering::lowerReturn(MachineIRBuilder &MIRBuilder, bool AMDGPUCallLowering::lowerReturn(MachineIRBuilder &MIRBuilder,
const Value *Val, unsigned VReg) const { const Value *Val, unsigned VReg) const {
// FIXME: Add support for non-void returns.
if (Val)
return false;
MIRBuilder.buildInstr(AMDGPU::S_ENDPGM); MIRBuilder.buildInstr(AMDGPU::S_ENDPGM);
return true; return true;
} }
unsigned AMDGPUCallLowering::lowerParameterPtr(MachineIRBuilder &MIRBuilder, unsigned AMDGPUCallLowering::lowerParameterPtr(MachineIRBuilder &MIRBuilder,
Type *ParamTy, Type *ParamTy,
unsigned Offset) const { unsigned Offset) const {
▲ Show 20 Lines • Show All 177 Lines • Show Last 20 Lines

test/CodeGen/AMDGPU/GlobalISel/todo.ll

  • This file was added.
; RUN: llc -mtriple=amdgcn-mesa-mesa3d -global-isel -global-isel-abort=2 %s -o - 2>&1 | FileCheck %s
; This isn't implemented, but we need to make sure we fall back to SelectionDAG
; instead of generating wrong code.
; CHECK: warning: Instruction selection used fallback path for non_void_ret
; CHECK: non_void_ret:
; CHECK-NOT: s_endpgm
define amdgpu_vs i32 @non_void_ret() {
ret i32 0
}