This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Set the default ABI version for Fuchsia in CMake as well
ClosedPublic

Authored by phosek on Apr 11 2018, 10:24 AM.

Diff Detail

Repository
rCXX libc++

Event Timeline

phosek created this revision.Apr 11 2018, 10:24 AM

This LGTM given that Eric accepted your previous change. I'm happy to accept it in a day or two if he hasn't gotten the chance to take a look by then.

libcxx/CMakeLists.txt
101

I prefer DEFAULT_ABI_VERSION to ABI_VERSION_DEFAULT

phosek updated this revision to Diff 142261.Apr 12 2018, 2:17 PM
phosek marked an inline comment as done.

I had something similar in D45304 but Eric suggested removing it. What I haven't realized is that this value is also used to set the SOVERSION so it's indeed needed.

OK, so we need to bump the SO version -- However I don't want to generate a site_config header because of that if the config header is sufficient. I would like to see a solution that takes that into account.

OK, so we need to bump the SO version -- However I don't want to generate a site_config header because of that if the config header is sufficient. I would like to see a solution that takes that into account.

There shouldn't be any __site_config generated now since we compare LIBCXX_ABI_VERSION to the default version so it'll only be generated if the change the default value (2 on Fuchsia, 1 everywhere else).

smeenai accepted this revision.Apr 12 2018, 5:22 PM

Eric accepted on IRC.

This revision is now accepted and ready to land.Apr 12 2018, 5:22 PM
This revision was automatically updated to reflect the committed changes.