Page MenuHomePhabricator

[dotest] Use in-tree dsymutil on Darwin
ClosedPublic

Authored by JDevlieghere on Apr 11 2018, 7:45 AM.

Details

Summary

With the upstream implementation of dsymutil containing almost all
functionality from the one shipped with Xcode, we want to use the
in-tree version for running the test suite.

This will also allow us to re-enable TestUnicodeSymbols which was
failing because of the discrepancy in how Unicode symbols were hashed in
lldb and older versions of dsymutil.

Event Timeline

JDevlieghere created this revision.Apr 11 2018, 7:45 AM
aprantl added inline comments.Apr 11 2018, 10:07 AM
packages/Python/lldbsuite/test/dotest.py
306

I suppose we could point to llvm-dsymutil even on non-darwin platforms? Might be useful if we want to have no-execute-Darwin tests running on Linux bots?

JDevlieghere added inline comments.Apr 11 2018, 10:15 AM
packages/Python/lldbsuite/test/dotest.py
306

Jup that is true, I'll change the logic to make that happen

  • Address Adrian's feedback
aprantl accepted this revision.Apr 11 2018, 10:19 AM
This revision is now accepted and ready to land.Apr 11 2018, 10:19 AM
davide accepted this revision.Apr 11 2018, 10:21 AM

LGTM

labath accepted this revision.Apr 12 2018, 1:25 AM
This revision was automatically updated to reflect the committed changes.