Page MenuHomePhabricator

Move Args.cpp from Interpreter to Utility
ClosedPublic

Authored by labath on Apr 10 2018, 3:16 AM.

Details

Summary

The Args class is used in plenty of places besides the command
interpreter (e.g., anything requiring an argc+argv combo, such as when
launching a process), so it needs to be in a lower layer. Now that the
class has no external dependencies, it can be moved down to the Utility
module.

This removes the last (direct) dependency from the Host module to
Interpreter, so I remove the Interpreter module from Host's dependency
list.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Apr 10 2018, 3:16 AM

This removes the last (direct) dependency from the Host module to Interpreter, so I remove the Interpreter module from Host's dependency list.

Big milestone! Kudos

This removes the last (direct) dependency from the Host module to Interpreter, so I remove the Interpreter module from Host's dependency list.

Big milestone! Kudos

Thanks. Host is still a member of a lot of cycles with other modules, but I think I have a plan on how to solve these as well.

I take it that everyone is ok with checking this in then.

davide accepted this revision.Apr 12 2018, 8:06 AM

No objections from me.

This revision is now accepted and ready to land.Apr 12 2018, 8:06 AM
This revision was automatically updated to reflect the committed changes.