Page MenuHomePhabricator

[Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests
ClosedPublic

Authored by phosek on Mar 31 2018, 8:39 PM.

Details

Summary

D30700 added the -f[no-]rtlib-add-rpath flag, but that flag was never
wired up in the driver and tests were updated to check whether it
actually does anything. This patch wires up the flag and updates test.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Mar 31 2018, 8:39 PM
pirama added a comment.EditedApr 2 2018, 11:04 AM

Hi Petr, thanks for the fix (I dropped the ball on this one :( ). Instead of duplicating the checks, does it make sense to fold check into addArchSpecificRPath and rename it to 'addArchSpecificRPathIfRequested' or something similar?

phosek updated this revision to Diff 140668.Apr 2 2018, 12:30 PM

Thanks for the suggestion, I don't think we even need to rename the function since this already matches the pattern other functions use.

pirama accepted this revision.Apr 2 2018, 1:15 PM
This revision is now accepted and ready to land.Apr 2 2018, 1:15 PM
This revision was automatically updated to reflect the committed changes.